Skip to content

Include version in Job Monitor user agent - #17430

Merged
mmitche merged 1 commit into
dotnet:mainfrom
mmitche:mmitche/version-job-monitor-user-agent
Aug 27, 2026
Merged

mmitche merged 1 commit into
dotnet:mainfrom
mmitche:mmitche/version-job-monitor-user-agent

Conversation

@mmitche

@mmitche mmitche commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary

Add the Job Monitor assembly informational version to the user-agent header on Azure DevOps requests.

Requests now identify as:

dotnet-helix-job-monitor/<informational-version>

This allows Azure DevOps service telemetry to distinguish traffic from different Job Monitor releases while preserving the existing product name. A focused test verifies the versioned header on the test-result upload path.

Validation

  • Microsoft.DotNet.Helix.Sdk.Tests: 300 passed

Identify Azure DevOps requests as dotnet-helix-job-monitor/<informational-version> so service-side telemetry can distinguish monitor releases.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 810f897d-3e88-4973-9e90-5e76fb0ba4bc
Copilot AI lite review requested due to automatic review settings August 27, 2026 19:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Helix Job Monitor’s Azure DevOps HTTP client to include the Job Monitor assembly’s informational version in the User-Agent header, enabling better service-side telemetry correlation across Job Monitor releases.

Changes:

  • Add a versioned User-Agent entry (dotnet-helix-job-monitor/<informational-version>) to Azure DevOps requests from Job Monitor.
  • Add a focused unit test that verifies the versioned header on the result upload path.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Microsoft.DotNet.Helix/JobMonitor/Services/AzureDevOpsService.cs Updates the Azure DevOps HttpClient initialization to send a versioned User-Agent product token.
src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/AzureDevOpsServiceTests.cs Adds a test asserting result upload requests include the expected versioned User-Agent.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mmitche
mmitche enabled auto-merge (squash) August 27, 2026 20:34
@mmitche
mmitche merged commit 2cdfe99 into dotnet:main Aug 27, 2026
10 of 12 checks passed
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants