[release/6.0] Backport refreshable Helix Entra authentication - #17565
Merged
missymessa merged 4 commits intoSep 15, 2026
Merged
missymessa merged 4 commits into
missymessa merged 4 commits into
Conversation
Copilot-Session: e890b71a-c1aa-416c-a15c-be8da9fdd9b4 Copilot-Session: 0e1a942f-a44f-4e3a-8d35-af3fe8bee535 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a6ad3a92-2023-4c67-8948-f6d34de1a67c Copilot-Session: 521e657d-a005-4f60-bcff-25a05ebcc390 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4aa6b2e8-2313-40c0-92f6-1d578db0af15 Copilot-Session: a891597e-6dca-4706-8628-004c5837d0c9
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical authentication-mode handling remains unresolved in repository Helix project consumers.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Backports refreshable Entra authentication for Helix clients, SDK tasks, and Azure Pipelines while preserving PAT and anonymous modes.
Changes:
- Adds scoped
TokenCredentialauthentication with refresh support. - Propagates authentication settings through SDK tasks and pipeline templates.
- Updates dependencies, tests, and documentation.
File summaries
| File | Reviewed change |
|---|---|
src/Microsoft.DotNet.Helix/Sdk/tools/Microsoft.DotNet.Helix.Sdk.props |
Defines Entra authentication settings. |
src/Microsoft.DotNet.Helix/Sdk/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets |
Propagates authentication to multi-queue tasks. |
src/Microsoft.DotNet.Helix/Sdk/tools/Microsoft.DotNet.Helix.Sdk.MonoQueue.targets |
Propagates authentication to job submission. |
src/Microsoft.DotNet.Helix/Sdk/SendHelixJob.cs |
Handles creator validation by authentication mode. |
src/Microsoft.DotNet.Helix/Sdk/Readme.md |
Documents SDK authentication options. |
src/Microsoft.DotNet.Helix/Sdk/Microsoft.DotNet.Helix.Sdk.csproj |
Adds Azure Identity and source-build support. |
src/Microsoft.DotNet.Helix/Sdk/HelixTask.cs |
Selects PAT, anonymous, or refreshable Entra clients. |
src/Microsoft.DotNet.Helix/Sdk/GetHelixWorkItems.cs |
Handles result links by authentication mode. |
src/Microsoft.DotNet.Helix/Sdk/CancelHelixJob.cs |
Supports Entra-authenticated cancellation. |
src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests.csproj |
Updates test references and dependencies. |
src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/HelixApiAuthenticationTests.cs |
Tests authentication selection, refresh, links, and cancellation. |
src/Microsoft.DotNet.Helix/Client/CSharp/Microsoft.DotNet.Helix.Client.csproj |
Aligns Azure client dependencies. |
src/Microsoft.DotNet.Helix/Client/CSharp/HelixApiOptions.cs |
Configures authentication modes, scopes, and bearer policies. |
src/Microsoft.DotNet.Helix/Client/CSharp/ApiFactory.cs |
Adds Entra-authenticated client factories. |
eng/common/templates/steps/send-to-helix.yml |
Configures Entra service connections for standard pipelines. |
eng/common/templates-official/steps/send-to-helix.yml |
Configures Entra service connections for official pipelines. |
Documentation/AzureDevOps/SendingJobsToHelix.md |
Documents Entra and legacy authentication setup. |
Review details
- Files reviewed: 17/17 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
One critical packaging issue and one moderate compatibility issue remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (1)
src/Microsoft.DotNet.Helix/Client/CSharp/HelixApiOptions.cs:67
- This
elsechanges the behavior of the existing publicHelixApiOptions(TokenCredential)/(Uri, TokenCredential)constructors for every customTokenCredentialthat is notHelixApiTokenCredential: before this changeInitializeOptionsattachedHelixApiTokenAuthenticationPolicy(the legacytokenheader and empty scopes), whereas it now attaches a Bearer policy and requests a Helix Entra scope. That is a behavioral breaking change for release/6.0 consumers using a custom credential; keep the legacy constructor on the PAT policy and add an explicit Entra constructor/marker for the new factory path.
else
{
AuthenticationMode = HelixApiAuthenticationMode.EntraId;
if (TokenScopes.Count == 0)
{
- Files reviewed: 20/20 changed files
- Comments generated: 1
- Review effort level: Lite
| <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" /> | ||
| <PackageReference Include="NuGet.Versioning" Version="$(NuGetVersion)" /> | ||
| <PackageReference Include="System.Net.Http" Version="4.3.4" /> | ||
| <PackageReference Include="Azure.Identity" Version="1.13.2" Condition="'$(DotNetBuildSourceOnly)' != 'true'" /> |
premun
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TokenCredential-based Helix client authentication with production/staging scopes.send-to-helix.ymltemplates.Microsoft.DotNet.ArcadeAzureIntegrationproject.Validation
DOTNET_ROLL_FORWARD=Major Build.cmd -projects src\Microsoft.DotNet.Helix\Sdk.Tests\Microsoft.DotNet.Helix.Sdk.Tests\Microsoft.DotNet.Helix.Sdk.Tests.csproj -testResult: 62 tests passed, 0 failed, 0 skipped, including focused coverage that verifies repository Helix consumers treat Entra mode as authenticated. Roll-forward is required locally because this branch targets netcoreapp3.1 while the repository bootstrap provides the .NET 6 runtime.
Intentionally omitted
The main-branch standalone JobMonitor project and
eng/common/core-templateschanges from #17537 are not included because those surfaces do not exist on release/6.0. Their files were not introduced solely for this backport.