Add (IL)linker opt-in flag#6936
Conversation
9994df7 to
f84fe92
Compare
If the Microsoft.NET.ILLink.Tasks package is package referenced directly, overwriting `ILLinkTasksAssembly` guarantees that the SDK uses the right ILLink assembly. Github org searches didn't show any consumer of the private properties, hence removing them for simplification. dotnet/arcade#6936 benefits from this change.
If the Microsoft.NET.ILLink.Tasks package is package referenced directly, overwriting `ILLinkTasksAssembly` guarantees that the SDK uses the right ILLink assembly. Github org searches didn't show any consumer of the private properties, hence removing them for simplification. dotnet/arcade#6936 benefits from this change.
What would be the benefit of it? The reason for the subscription is to have fast updates in runtime which with arcade won't be possible |
Same as for dotnet/roslyn (in regards to their compiler package), that would make sure that core repositories in the stack use a consistent version of the linker so that sourcebuild doesn't need to build multiple different versions.
Arcade ingests roughly 3 times per week and we are fine with that pacing for the compiler package. If we need faster updates for ILLink, we can keep the subscription in dotnet/runtime. |
I believe we do. |
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* Add (IL)linker opt-in flag
If the Microsoft.NET.ILLink.Tasks package is package referenced directly, overwriting `ILLinkTasksAssembly` guarantees that the SDK uses the right ILLink assembly. Github org searches didn't show any consumer of the private properties, hence removing them for simplification. dotnet/arcade#6936 benefits from this change. Commit migrated from dotnet/linker@7f47c0c
This is similar to the compiler package which overrides what's inbox in dotnet/sdk. Exposing the illinker via a property as an opt-in to guarantee that the right package is used throughout the repository as msbuild caches tasks and even with ALC there is currently no way to prevent that.
TODO post merge: