This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix x86 dumps from HandleFatalError showing misleading callstack - #23289
Merged
Merged
Conversation
jeffschwMSFT
approved these changes
Mar 15, 2019
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
lgtm (nice that we now have PLATFORM_WINDOWS)
elinor-fung
force-pushed
the
dumpsContext-x86
branch
from
March 15, 2019 21:55
9c47f3f to
003b89d
Compare
Member
Author
|
@dotnet-bot test Ubuntu x64 Checked Innerloop Build and Test |
Member
Author
|
@dotnet-bot test Ubuntu x64 Checked CoreFX Tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port from full Framework
Example before:
[0x0] coreclr!EEJitManager::IsAltJitLoaded
[0x1] coreclr!UnsafeJitFunction + 0x135f16
[0x2] coreclr!MethodDesc::JitCompileCodeLocked + 0x1bd
Example after:
[0x0] coreclr!EEPolicy::HandleFatalError + 0x96
[0x1] coreclr!UnsafeJitFunction + 0x362
[0x2] coreclr!MethodDesc::JitCompileCodeLocked + 0x23b