Build SOS interpreter test assets when enabled - #6015
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped to test harness/config behavior and the updated settings align with how the harness composes host+debuggee command lines and consumes DesktopRuntimePath.
Pull request overview
This PR fixes remaining SOS test harness failures in the runtime-diagnostics pipeline by ensuring interpreter-based debuggees run against the intended framework version, and by correctly switching SOS from cDAC to the legacy DAC when moving to the desktop (.NET Framework) runtime in the dual-runtime scenario.
Changes:
- Launch framework-dependent debuggees via
dotnet exec --fx-version ...on both Windows and Unix configurations. - Provide an explicit desktop runtime directory to
SOS.DualRuntimessosetclrpathcan load the correct legacy DAC. - Disable cDAC (
runtimes --usecdac false) prior to selecting the desktop runtime in the dual-runtime script flow.
File summaries
| File | Description |
|---|---|
| src/tests/SOS.UnitTests/Scripts/DualRuntimes.script | Forces legacy DAC before switching to desktop runtime and sets the desktop CLR path for correct desktop DAC loading. |
| src/tests/SOS.UnitTests/ConfigFiles/Windows/Debugger.Tests.Config.txt | Passes the desktop runtime directory to the DualRuntimes test and updates host args to use dotnet exec --fx-version. |
| src/tests/SOS.UnitTests/ConfigFiles/Unix/Debugger.Tests.Config.txt | Updates host args to use dotnet exec --fx-version for framework-dependent debuggees. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
max-charlamb
marked this pull request as draft
September 9, 2026 14:28
max-charlamb
marked this pull request as ready for review
September 9, 2026 15:48
max-charlamb
force-pushed
the
dev/max-charlamb/fix-sos-host-and-dual-runtime
branch
from
September 9, 2026 16:37
6a09488 to
6febc4b
Compare
steveisok
approved these changes
Sep 9, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7b2ca30d-742d-402c-8ba5-afec8b6d69a1
max-charlamb
force-pushed
the
dev/max-charlamb/fix-sos-host-and-dual-runtime
branch
from
September 9, 2026 17:02
6febc4b to
a1a6229
Compare
rcj1
approved these changes
Sep 9, 2026
max-charlamb
enabled auto-merge (squash)
September 9, 2026 18:06
Member
Author
|
/ba-g known flaky tests |
max-charlamb
disabled auto-merge
September 9, 2026 18:41
max-charlamb
deleted the
dev/max-charlamb/fix-sos-host-and-dual-runtime
branch
September 9, 2026 18:41
This was referenced Sep 9, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
-testInterpretersetSOS_TEST_INTERPRETERbefore the managed build as well as during test execution.The runtime-diagnostics pipeline separates diagnostics build and test into different processes. Previously,
-testInterpreterwas passed only to the test invocation, so the tests were enabled but the interpreter debuggee projects had already been skipped during the build.The companion runtime pipeline commit passes
-testInterpreterto the diagnostics build step: dotnet/runtime@e3dc2ea6a39This addresses the interpreter failures in: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1587921
Validation
Removed the generated interpreter outputs and confirmed that a managed build with
-testInterpreterrecreatedInterpreterStackTest,InterpreterStackInterleavedTest, andTrampolinefornet11.0.Note
This pull request description was generated with GitHub Copilot.