Shard SOS Helix tests by runtime - #6029
Merged
max-charlamb merged 3 commits intoSep 15, 2026
Merged
Conversation
Run each configured runtime in a separate Helix work item and keep desktop Framework coverage in its own Windows work item. Add Debug SOS coverage alongside Release for non-PR public builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90d32376-768b-4f8c-a982-54247c372cf3
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical Windows and internal-release compatibility issues remain, along with an inconsistent macOS Debug/Release job configuration.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Shards SOS Helix tests by .NET runtime, separates Windows Framework coverage, and adds public non-PR Debug/Release scheduling.
Changes:
- Generates runtime-specific and Framework-specific Helix work items.
- Applies shard filters in Unix and Windows launchers.
- Adds public non-PR Debug SOS jobs and artifacts.
File summaries
| File | Description |
|---|---|
src/tests/SOS.Tests/README.md |
Documents Helix sharding. |
src/tests/SOS.Tests/HelixPayload.targets |
Generates and dispatches shard work items. |
src/tests/SOS.Tests/Helix/run-sos-tests.sh |
Applies Unix shard filters. |
src/tests/SOS.Tests/Helix/run-sos-tests.cmd |
Applies Windows shard filters. |
eng/helix/SendToHelix.proj |
Dispatches multiple Helix work items. |
diagnostics.yml |
Adds public non-PR Debug SOS jobs and artifacts. |
Review details
Suppressed comments (1)
diagnostics.yml:505
- The new non-PR build publishes
MacOS_x64_Debug, but this is the onlySOS_Helix_MacOS_x64entry and it is configured as Release in the following lines. Consequently public non-PR builds spend time producing an unused Debug artifact and never run the promised x64 macOS Debug SOS coverage. Add a matchingMacOS_x64_DebugSOS job (while retaining Release if both are required), or remove the unused Debug build configuration.
- template: /eng/pipelines/sos-helix.yml
parameters:
jobTemplate: ${{ variables.jobTemplate }}
name: SOS_Helix_MacOS_x64_Debug
osGroup: MacOS
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
added 2 commits
September 14, 2026 14:49
Enable delayed expansion and materialize the hyphen-delimited work-item tokens before selecting the runtime or Framework shard. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90d32376-768b-4f8c-a982-54247c372cf3
Materialize the runtime shard item list into a scalar property before passing it to the nested MSBuild invocation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90d32376-768b-4f8c-a982-54247c372cf3
steveisok
approved these changes
Sep 15, 2026
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also expands non-PR public (rolling) SOS coverage from Release-only to both Debug and Release. Pull request validation remains Debug-only.
Summary
Validation
CI timing
We will compare this PR's SOS Helix duration with the successful pre-sharding build 1595840.