Simplify SOS Helix pipeline matrix - #6035
Merged
max-charlamb merged 5 commits intoSep 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
PR SOS jobs request Release artifacts that the PR build legs do not publish.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Simplifies SOS Helix pipeline generation with a reusable platform matrix.
Changes:
- Centralizes platform-specific pipeline metadata.
- Refactors SOS Helix job generation and artifact naming.
- Removes the obsolete Helix platform variables template.
- Configures Release PR coverage and Debug non-PR coverage.
File summaries
| File | Summary |
|---|---|
diagnostics.yml |
Uses the new SOS matrix; critical issue: PR jobs request Release artifacts while PR builds publish Debug artifacts (3 votes). |
eng/pipelines/platform-matrix.yml |
Defines reusable platform-specific pipeline settings. |
eng/pipelines/sos-helix.yml |
Generates SOS Helix jobs from matrix parameters. |
eng/pipelines/helix-platforms.yml |
Removes obsolete queue and platform variables. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
max-charlamb
force-pushed
the
sos-helix-platform-matrix
branch
from
September 16, 2026 13:43
71d9a12 to
3282fa3
Compare
steveisok
approved these changes
Sep 16, 2026
max-charlamb
force-pushed
the
sos-helix-platform-matrix
branch
from
September 16, 2026 20:53
1aa28ce to
1ccc649
Compare
steveisok
approved these changes
Sep 16, 2026
Member
|
Have you run the official build against this? And rebased it with the changes from today? |
added 3 commits
September 17, 2026 12:18
Use a shared explicit platform matrix for build, test, and SOS Helix jobs while preserving separate build and test stages. Select Azure containers and Helix queues through explicit platform metadata, and remove the disabled CodeQL pipeline definition. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90d32376-768b-4f8c-a982-54247c372cf3
Use one literal queue key per platform to select build and test containers and resolve Helix queues at runtime. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90d32376-768b-4f8c-a982-54247c372cf3
Use the Ubuntu 22.04 SOS-compatible image for the test_linux_x64 resource and remove the redundant test_ubuntu_22_04 alias. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90d32376-768b-4f8c-a982-54247c372cf3
max-charlamb
force-pushed
the
sos-helix-platform-matrix
branch
from
September 17, 2026 16:19
1ccc649 to
df5649d
Compare
added 2 commits
September 17, 2026 13:40
Use the boolean official-build flag directly so failed test execution, test result publication, and SOS submission produce succeeded-with-issues results only for official builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90d32376-768b-4f8c-a982-54247c372cf3
Forward the boolean official-build state explicitly through the platform matrix so nested job templates can use it for continue-on-error behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90d32376-768b-4f8c-a982-54247c372cf3
Member
Author
Yes, I rebased on the other pipeline changes and have an official build queued: https://dev.azure.com/dnceng/internal/_build/results?buildId=3079281 |
steveisok
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --check