Restore build and test stage separation - #6036
Merged
Merged
Conversation
Move test and SOS Helix jobs back into the test stage while preserving artifact-based execution. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 79f15e34-e782-41ec-add6-8b3351cdc967
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The package stage may publish artifacts before the new test stage completes; it should also depend on test.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Restores a dedicated test stage for diagnostics and SOS Helix jobs after #6019.
Changes:
- Makes test-stage job dependencies optional.
- Moves tests and SOS Helix jobs into a stage dependent on
build. - Preserves artifact consumption across stages.
File summaries
| File | Description |
|---|---|
eng/pipelines/sos-helix.yml |
Makes Helix job dependencies optional. |
eng/pipelines/build.yml |
Avoids invalid cross-stage dependencies for test jobs. |
diagnostics.yml |
Adds the dedicated test stage and updates test job placement. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
max-charlamb
approved these changes
Sep 15, 2026
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the dedicated test stage for test and SOS Helix jobs after #6019.