Fix redirect 404 false positive - #10
Merged
Merged
Conversation
gewarren
requested
a lite review from Copilot
and removed request for
BillWagner
September 19, 2026 03:51
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate correctness issues remain in target eligibility and path containment.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
Fixes false-positive 404s when redirect targets exist in the repository.
Changes:
- Adds repository target detection for
/dotnet/redirects. - Suppresses 404s for detected targets.
- Adds unit coverage for the suppression path.
| File | Summary |
|---|---|
docs-verifier/src/RedirectionVerifier/RedirectTargetVerifier.cs |
Adds local target resolution and 404 suppression; moderate issues remain around limiting exemptions to newly added files and preventing path escapes. |
docs-verifier/tests/GitHub.UnitTests/RedirectTargetVerifierTests.cs |
Adds suppression coverage; nit remains for testing the default repository lookup predicate. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refactor redirect path handling to include validation for relative paths and ensure safety against directory traversal attacks. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Absolute candidate paths do not match the repository-relative tracked paths, so the 404 exemption is not applied.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9