Skip to content

Rework the AIFunctionFactory APIs and remove redundant overloads following removal of trimmer annotations. - #5510

Merged
eiriktsarpalis merged 4 commits into
dotnet:mainfrom
eiriktsarpalis:remote-redundant-overloads
Oct 11, 2024
Merged

Rework the AIFunctionFactory APIs and remove redundant overloads following removal of trimmer annotations.#5510
eiriktsarpalis merged 4 commits into
dotnet:mainfrom
eiriktsarpalis:remote-redundant-overloads

Conversation

@eiriktsarpalis

@eiriktsarpalis eiriktsarpalis commented Oct 11, 2024 •
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Follow-up work to #5507

Microsoft Reviewers: Open in CodeFlow

@eiriktsarpalis
eiriktsarpalis requested a review from a team as a code owner October 11, 2024 13:10
stephentoub
stephentoub reviewed Oct 11, 2024
View reviewed changes
Comment thread src/Libraries/Microsoft.Extensions.AI/Functions/AIFunctionFactory.cs Outdated
stephentoub
stephentoub reviewed Oct 11, 2024
View reviewed changes
Comment thread src/Libraries/Microsoft.Extensions.AI/Functions/AIFunctionFactory.cs Outdated
stephentoub
stephentoub reviewed Oct 11, 2024
View reviewed changes
Comment thread src/Libraries/Microsoft.Extensions.AI/Functions/AIFunctionFactory.cs
@eiriktsarpalis

eiriktsarpalis commented Oct 11, 2024

Copy link
Copy Markdown
Member Author

I pushed more changes adding a new MethodInfo overload that matches the Delegate accelerator. One source breaking change this introduces is making the object? target parameter non-optional. I think this is goodness because it forces users to be deliberate as to whether they're passing a static or instance method.

stephentoub
stephentoub reviewed Oct 11, 2024
View reviewed changes
Comment thread src/Libraries/Microsoft.Extensions.AI/Functions/AIFunctionFactory.cs
@eiriktsarpalis
eiriktsarpalis merged commit 6249779 into dotnet:main Oct 11, 2024
@eiriktsarpalis
eiriktsarpalis deleted the remote-redundant-overloads branch October 11, 2024 17:47
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 11, 2024
@jeffhandley jeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes
@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees

@eiriktsarpalis eiriktsarpalis

Labels

area-ai Microsoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eiriktsarpalis @stephentoub @jeffhandley