Port NUnit based tests to Core CLR

[PatrickMcDonald]

coreclr status: https://github.com/Microsoft/visualfsharp/wiki/F%23-for-CoreCLR---Status

I can start looking at this task for the CoreCLR project

[KevinRansom]

Thank you, that would be awesome. You will have to make the tests build on coreclr first. Which is going to be an interesting challenge. Good luck.

[PatrickMcDonald]

Have reached first hurdle well before looking at actually compiling on coreclr. I can't get the project to compile against Profile47 using xUnit.net. Is this surprising or expected?

xUnit.net seems to support portable-net45+win8+wp8+wpa81, whereas Profile47 includes Silverlight 5

The workaround for a similar issue with FsCheck was to exclude those tests for 47, but I have a feeling that won't fly this time.

Edit: Code so far is in this branch

[PatrickMcDonald]

Also, @KevinRansom, I hope your comment yesterday wasn't intended to be encouraging, because it wasn't ;)

[enricosada]

xunit require .net desktop > 4.5 , we cannot use it for .net 3.5

[forki]

why is this change of framework needed?

[enricosada]

see #688 ,

1. Port the Nunit tests to XUnit 2.0. (XUnit is what Roslyn and .NetCore use).

[forki]

but that's only a fact not a real reason.
AFAIK NUnit is also working on coreclr support.

[enricosada]

yes, not ready yet but maybe we can meawhile upgrade nunit 2.1 -> 3.0, and wait for dnx support

ref nunit/nunit#575

in the last bet5, there is support for coreclr (need build from sourcecode) see Release-Notes nunit-300-beta-5

The NUnit framework may now be built for the .NET Core framework. Note that this is only available through building the source code. A binary will be available in the next release

Ihmo is better to stay on nunit, upgrade to 3.0 in main branch, port fsharp/fsharpqa to use nunit runner, and wait for full compatibility of nunit.
If nunit drop a target profile, we can anyway stub methods, and run with nunit 2.x, easier than xunit -> nunit migration

[KevinRansom]

@forki Where possible we will use the same tooling as dotnet and coreclr OSS projects. This allows us to leverage work they do.

[rprouse]

NUnit has a new PR nunit/nunit#915 that adds .NET core support. We still need to test on various platforms and get 3.0 out, but we are close 👍

[forki]

Yes reusing other people's work is a good idea. But here we should be
careful if that's really helpful. Changing test frameworks comes with lots
of trouble (but keeping outdated ones too ;-) ).

When nunit allows us to keep working with it, then I personally would not
want to change. Especially xunit2 has been a nightmare for me in the past.
On Oct 21, 2015 9:28 PM, "Kevin Ransom (msft)" notifications@github.com
wrote:

@forki https://github.com/forki Where possible we will use the same
tooling as dotnet and coreclr OSS projects. This allows us to leverage work
they do.

—
Reply to this email directly or view it on GitHub
#690 (comment)
.

[radekm]

Does xUnit.net 2 work with Mono?

[forki]

Yes latest mono versions should support latest xunit2.
On Oct 22, 2015 12:08 AM, "radekm" notifications@github.com wrote:

Does xUnit.net 2 work with Mono?

—
Reply to this email directly or view it on GitHub
#690 (comment)
.