You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you @Martin521 for fixing it that quickly.
Surprisingly we do not have any tests for VS.FSI, the window in VS itself - replicating that as standalone F# snippet has to suffice.
The failing test is puzzling me.
The test fails only in the two Windows...Desktop4 jobs, but consistently.
It fails because instead of Error 1204 a Warning 1204 is reported.
It seems this #if directive evaluates differently.
But I have no idea why this is happening for this PR and not for other PRs that ran today.
It seems to be impossible that this is related to my changes.
@Martin521 : It is deterministic, I also do not believe this is a flaky test anymore.
Something in this change is causing a difference in how the diagnostic gets produced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18908
That was easier than I thought.
Checklist