Skip to content

Migrate devdiv/dotnet-core-internal-tooling to WIF service connection#20036

Merged
T-Gro merged 1 commit into
dotnet:mainfrom
missymessa:dev/mjanecke/migrate-dotnet-core-internal-tooling-wif
Jul 7, 2026
Merged

Migrate devdiv/dotnet-core-internal-tooling to WIF service connection#20036
T-Gro merged 1 commit into
dotnet:mainfrom
missymessa:dev/mjanecke/migrate-dotnet-core-internal-tooling-wif

Conversation

@missymessa

@missymessa missymessa commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

Replace PAT-backed externalnugetfeed SC with WIF-based azureDevOpsServiceConnection for the devdiv/dotnet-core-internal-tooling NuGet feed.

Motivation

Part of PAT disable policy migration (dnceng WI 10124).

Changes

  • Before: nuGetServiceConnections: 'devdiv/dotnet-core-internal-tooling' (PAT-based ExternalNuGetFeed SC)
  • After: azureDevOpsServiceConnection + feedUrl (WIF SC backed by Entra app)

New Service Connection

Same pattern as the devdiv/engineering feed migration (dotnet/roslyn#83918, dotnet/dotnet#6902).

@missymessa
Migrate devdiv/dotnet-core-internal-tooling to WIF service connection
e55a3e7 
Replace PAT-backed externalnugetfeed SC with WIF-based
azureDevOpsServiceConnection for the devdiv/dotnet-core-internal-tooling
NuGet feed. Part of PAT disable policy migration (WI 10124).

New SC: dnceng-devdiv-dotnet-core-internal-tooling-feed-rw-wif
@missymessa
missymessa requested a review from a team as a code owner July 6, 2026 21:32
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

✅ No release notes required

@github-actions github-actions Bot added ⚠️ Affects-Build-Infra Tooling check: PR touches build infrastructure ⚠️ Affects-Restore Tooling check: PR touches NuGet packages or feeds labels Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Restore
Affects-Build-Infra: modifies eng/restore-internal-tools.yml (CI pipeline)
Affects-Restore: changes NuGet feed auth method and feed URL

Generated by PR Tooling Safety Check · opus46 2.9M · ◷

@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Jul 7, 2026
@T-Gro
T-Gro merged commit a7ee438 into dotnet:main Jul 7, 2026
57 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in F# Compiler and Tooling Jul 7, 2026
This was referenced Jul 7, 2026
Merged
Merged
Merged
T-Gro added a commit that referenced this pull request Jul 8, 2026
@github-actions @T-Gro
@missymessa @dotnet-maestro
[automated] Merge branch 'main' => 'feature/net11-scouting' (#20039)
a6626ac 
* Emit FS0755 for CompiledName on multi-value let-bindings (#19924)

* Show [<Literal>] and constant value for IL fields in Go to Metadata (#19922)

* Fix shouldBeParenthesizedInContext for Sequential in record fields (#17826) (#19850)

* Migrate devdiv/dotnet-core-internal-tooling to WIF service connection (#20036)

Replace PAT-backed externalnugetfeed SC with WIF-based
azureDevOpsServiceConnection for the devdiv/dotnet-core-internal-tooling
NuGet feed. Part of PAT disable policy migration (WI 10124).

New SC: dnceng-devdiv-dotnet-core-internal-tooling-feed-rw-wif

* Make parallel and sequential code generation byte-identical (#19929)

* Update dependencies from https://github.com/dotnet/roslyn build 20260706.6 (#20037)

On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.10.0-1.26352.10 -> To Version 5.10.0-1.26356.6

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Fix ppc64le stack overflow from deep Sequential chains in graph checking (#20028)

* Fix #13099: optimizer drops side-effectful receiver of unit member access in task CE (#19885)

* Reset files to feature/net11-scouting

Reset patterns:
- global.json
- eng/Version.Details.xml
- eng/Version.Details.props
- eng/Versions.props
- eng/common/**
- eng/TargetFrameworks.props

* Update dependencies from https://github.com/dotnet/roslyn build 20260707.6 (#20042)

On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.10.0-1.26356.6 -> To Version 5.10.0-1.26357.6

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Update dependencies from https://github.com/dotnet/msbuild build 20260707.8 (#20041)

On relative base path root
Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core From Version 18.10.0-preview-26353-05 -> To Version 18.10.0-preview-26357-08

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

---------

Co-authored-by: Tomas Grosup <Tomas.Grosup@gmail.com>
Co-authored-by: Missy Messa <47990216+missymessa@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
T-Gro added a commit that referenced this pull request Jul 9, 2026
@dotnet-maestro @T-Gro
@missymessa
[feature/net11-scouting] Update dependencies from dotnet/arcade (#20034)
b3c5124 
* Update dependencies from https://github.com/dotnet/arcade build 20260630.1
On relative base path root
Microsoft.DotNet.Arcade.Sdk From Version 11.0.0-beta.26325.1 -> To Version 11.0.0-beta.26330.1

* Emit FS0755 for CompiledName on multi-value let-bindings (#19924)

* Show [<Literal>] and constant value for IL fields in Go to Metadata (#19922)

* Fix shouldBeParenthesizedInContext for Sequential in record fields (#17826) (#19850)

* Migrate devdiv/dotnet-core-internal-tooling to WIF service connection (#20036)

Replace PAT-backed externalnugetfeed SC with WIF-based
azureDevOpsServiceConnection for the devdiv/dotnet-core-internal-tooling
NuGet feed. Part of PAT disable policy migration (WI 10124).

New SC: dnceng-devdiv-dotnet-core-internal-tooling-feed-rw-wif

* Make parallel and sequential code generation byte-identical (#19929)

* Update dependencies from https://github.com/dotnet/roslyn build 20260706.6 (#20037)

On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.10.0-1.26352.10 -> To Version 5.10.0-1.26356.6

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Fix ppc64le stack overflow from deep Sequential chains in graph checking (#20028)

* Re-trigger CI (flaky FSharp.Compiler.Service.Tests hang)

The WindowsNoRealsig_testCoreclr leg failed because the FSharp.Compiler.Service.Tests (net11.0) assembly hung and was killed by the 5-minute hangdump (exit 57005), with no deterministic test failure (error:1, failed:0). This is unrelated to the arcade SDK bump, which only touches build infra. Empty commit to re-run CI.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix #13099: optimizer drops side-effectful receiver of unit member access in task CE (#19885)

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <Tomas.Grosup@gmail.com>
Co-authored-by: Missy Messa <47990216+missymessa@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro pushed a commit that referenced this pull request Jul 21, 2026
T-Gro
CI: restore pipeline validity after the devdiv service connection was…
7e42638 
… removed

The 'DevDiv - VS package feed' service connection this pipeline used to authenticate the devdiv 'VS' feed
(serviced VS-2017 Roslyn 2.10) was removed/disabled during the org PAT-disable policy migration (cf. PR
#20036). Its literal reference in NuGetAuthenticate made pipeline 499's YAML fail compile-time validation,
which blocked ALL builds (product included) - not a code regression (builds were green at 8387e3f on 07/09;
the connection went away before the next queue on 07/21).

Gate the entire devdiv/insertion/signing surface (the group, mb.signing, the VSIX artifact, the devdiv
NuGetAuthenticate step, and BUILD_INSERTION/SignType/OfficialBuildId) behind a new _DevDivServiceConnection
variable. Empty (default) -> product + tests only, YAML valid, green. Set it to the replacement connection
name -> full insertion + signed VSIX restored (one-line change). All insertion machinery (CIBuild Steps 5/5b/6,
TP vendoring, signing) is preserved.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-bot dotnet-bot mentioned this pull request Jul 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

Assignees

No one assigned

Labels

⚠️ Affects-Build-Infra Tooling check: PR touches build infrastructure ⚠️ Affects-Restore Tooling check: PR touches NuGet packages or feeds

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@missymessa @T-Gro