Tests/source context: support multiple carets - #20077
Merged
Merged
Conversation
auduchinok
force-pushed
the
tests-sourceContext-multipleCarets
branch
from
July 22, 2026 15:07
a07da7d to
0bf814c
Compare
T-Gro
approved these changes
Jul 22, 2026
T-Gro
enabled auto-merge (squash)
July 22, 2026 16:08
T-Gro
added a commit
that referenced
this pull request
Jul 22, 2026
Builds on the multi-caret support (SourceContext.extractOrderedMarkedSources) cherry-picked from #20077. Multi-position goto-def tests now embed ordered {caret1}/{caret2}/... markers in a single source and assert via a new assertGoToDefinitionOnLines helper, instead of the markCaretAfterLeadingIdent substring helper. Removes the now-unused markCaretAfterLeadingIdent and isIdentChar. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9d20cd22-45dc-411f-9163-185fd6dd54d9
Member
|
Using your helpers for the multi-caret cases now — thanks! 🙏 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for multiple carets, as required for #20033.