Skip to content
This repository was archived by the owner on Jul 6, 2026. It is now read-only.

[generator] Strip arity from Cecil imported generic types.#450

Merged
jonpryor merged 1 commit into
masterfrom
strip-arity
Jul 19, 2019
Merged

[generator] Strip arity from Cecil imported generic types.#450
jonpryor merged 1 commit into
masterfrom
strip-arity

Conversation

@jpobst

@jpobst jpobst commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

One of the issues trying to bind the BouncyCastle .jar in dotnet/android#11928 is that we write generic types with invalid signatures, like:

public List`1<string> MyProperty { get; set; }

This is how a Cecil type reference FullName is returned. Since this notation is not useful to us, this PR strips the arity while reading the assembly.

This results in the proper type syntax:

public List<string> MyProperty { get; set; }

@jpobst jpobst changed the title [generator] Strip arity from Cecil imported types. [generator] Strip arity from Cecil imported generic types. Jul 19, 2019
@jonpryor
jonpryor merged commit 262743b into master Jul 19, 2019
@jpobst
jpobst deleted the strip-arity branch July 19, 2019 21:18
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants