Explicit objcopy definition#2909
Merged
Merged
Conversation
cincuranet
marked this pull request as ready for review
February 22, 2023 13:30
cincuranet
requested review from
DrewScoggins,
LoopedBard3,
caaavik-msft and
sblom
February 22, 2023 13:30
Contributor
Author
|
cc @eerhardt |
LoopedBard3
reviewed
Feb 22, 2023
LoopedBard3
left a comment
Member
There was a problem hiding this comment.
Could you expand on what the additional '/p:ObjCopyName=objcopy' does? Taking a quick look online did not come up with anything specific.
Contributor
Author
|
It's described here: dotnet/runtime#81517 (comment). |
eerhardt
reviewed
Feb 22, 2023
| exename=EXENAME, | ||
| working_directory=sys.path[0]) | ||
| precommands.execute(['/p:PublishAot=true', '/p:StripSymbols=true', '/p:IlcGenerateMstatFile=true']) | ||
| args = ['/p:PublishAot=true', '/p:StripSymbols=true', '/p:IlcGenerateMstatFile=true'] if iswin() else ['/p:PublishAot=true', '/p:StripSymbols=true', '/p:IlcGenerateMstatFile=true', '/p:ObjCopyName=objcopy'] |
Member
There was a problem hiding this comment.
args = ['/p:PublishAot=true', '/p:StripSymbols=true', '/p:IlcGenerateMstatFile=true']
if not iswin():
args.append('/p:ObjCopyName=objcopy')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure to use proper one when building the NativeAOT app.