Skip to content

don't trigger the CI if only a doc file was changed#355

Merged
adamsitnik merged 4 commits into
dotnet:masterfrom
adamsitnik:excludeDocs
Mar 4, 2019
Merged

don't trigger the CI if only a doc file was changed#355
adamsitnik merged 4 commits into
dotnet:masterfrom
adamsitnik:excludeDocs

Conversation

@adamsitnik

Copy link
Copy Markdown
Member

No description provided.

@adamsitnik

Copy link
Copy Markdown
Member Author

@adiaaida @billwert as we talked last week, we should not trigger the CI if only a doc file was changed

based on https://docs.microsoft.com/en-us/azure/devops/pipelines/build/triggers?view=azure-devops&tabs=yaml#paths

@adiaaida could you please take a look?

@adamsitnik
adamsitnik marked this pull request as ready for review March 4, 2019 12:57
@adamsitnik
adamsitnik merged commit 3742647 into dotnet:master Mar 4, 2019
@adamsitnik
adamsitnik deleted the excludeDocs branch March 4, 2019 17:30
@billwert

Copy link
Copy Markdown
Contributor

@adamsitnik @adiaaida does this work? I was surprised to see CI running on my other PR, and even on this PR it seems to have done the whole thing (since it ran 22 checks.) Shouldn't this PR have not had those checks run if this had the desired effect?

@billwert

Copy link
Copy Markdown
Contributor

sorry I guess this one should but #392 seems like it should not?

@michellemcdaniel

Copy link
Copy Markdown
Contributor

I wonder if the **/*.md syntax doesn't work quite how we expect it to.

@billwert

Copy link
Copy Markdown
Contributor

seems we're not the only ones. MicrosoftDocs/vsts-docs#2363. looking at the doc it says the wildcard has to be at the end. so docs/* is fine. @adiaaida do you know where AzDo feature requests get tracked? It'd be nice if this worked.. In the mean time I'll change the paths to be docs/* and all the relative paths to the .md files in the repo.

@michellemcdaniel

Copy link
Copy Markdown
Contributor

@chcosta Who should we contact for AzDO feature requests?

@adamsitnik

Copy link
Copy Markdown
Member Author

looking at the doc it says the wildcard has to be at the end

it explains why it worked for #364 but did not work for this PR. It would be great if AzDO could fix it

@chcosta

chcosta commented Mar 20, 2019

Copy link
Copy Markdown
Member

Please file an issue in https://dnceng.visualstudio.com/internal/_workitems/recentlyupdated/ (set "internal/VSTS" as the Area) and I'll bring this up with Azure DevOps.

@billwert

Copy link
Copy Markdown
Contributor

done thanks @chcosta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants