Remove Optimize define#391
Conversation
Defining Optimize in the project file is not precisely the same as specifying -c Release. (For example, DEBUG is defined instead of RELEASE, so any code which has tracing will include that tracing.) Instead of continuing to chase down all the ways it is different I think just pulling this out and requiring users to pass -c Release is a good path.
|
this fixes #390 |
adamsitnik
left a comment
There was a problem hiding this comment.
@billwert could you please also update the docs as well?
https://github.com/dotnet/performance/blob/master/docs/benchmarkdotnet.md
https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-corefx.md
https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow.md
https://github.com/dotnet/performance/blob/master/src/benchmarks/micro/README.md
|
@adamsitnik good catch, will do. |
In dotnet#391 I changed how `dotnet run` needs to be invoked but didn't clean up the docs.
* fixup docs In #391 I changed how `dotnet run` needs to be invoked but didn't clean up the docs. * remove blank line * swap numbered list for bullets This isn't really a set of steps, but a group of examples. Numbers aren't necessary.
|
Should there be an error or warning if I don't pass Release? Although IIRC BDN will warn. |
|
It should be possible to have a warning/error if |
|
@danmosemsft: |
Defining Optimize in the project file is not precisely the same as specifying -c Release. (For example, DEBUG is defined instead of RELEASE, so any code which has tracing will include that tracing.) Instead of continuing to chase down all the ways it is different I think just pulling this out and requiring users to pass -c Release is a good path.