Enable Jil for CoreCLR WASM R2R - #5317
Merged
Merged
Conversation
The wasm codegen issue that produced invalid Jil ISO8601 TimeSpan deserializers was fixed by dotnet/runtime#133210, merged as a5b8d110306eff632cced48a4d108d619393a6a4. Remove the temporary Jil.dll R2R exclusion so the CoreCLR browser-WASM lane compiles it normally again. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain, and all reviewers assessed it as ready.
Review effort: Lite
Findings: None
What changed in this PR
Removes the temporary Jil ReadyToRun exclusion for CoreCLR WASM now that the underlying WebAssembly codegen issue is fixed.
Changes:
- Enables Jil compilation with CoreCLR WASM R2R.
| File | Description |
|---|---|
src/benchmarks/micro/MicroBenchmarks.Wasm.targets |
Removes the conditional Jil.dll exclusion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LoopedBard3
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the temporary
Jil.dllPublishReadyToRunExcludefrom the CoreCLR browser-WASM R2R configuration so Jil is compiled normally in the lane again.The exclusion worked around invalid WebAssembly emitted for Jil's
ISO8601TimeSpan_FractionToTicksmethod. That wasm codegen bug is tracked by dotnet/runtime#133209 and was fixed by dotnet/runtime#133210, merged in runtime commita5b8d110306eff632cced48a4d108d619393a6a4.Validation
python3 -m pytest -q scripts/tests/test_wasm_coreclr_r2r.py— 35 passedgit diff --checkFull local browser-WASM artifact execution was not completed before opening this PR; validation is based on the focused performance-repository test suite and the merged runtime regression/fix for the exact Jil failure mode.