Skip to content

[RuntimeAsync] TODOs in asyncthunks about methodtables directly encoded in signatures. #121754

Description

@VSadov

There are 3 TODOs in the shape like:

    // TODO: (async) Encoding potentially shared method tables in
    // signatures of tokens seems odd, but this hits assert
    // with the typical method table.
    typeSigBuilder.AppendPointer(md->GetMethodTable());
    typeSigBuilder.AppendData(1);

We need to follow up on this and remove the TODOs as a result of:

  • confirming that what we have is correct. Perhaps add a comment why it is correct.
  • fix the code and ideally add tests.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    • Status
      No status

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions