Teach the DAC how to unwrap ComWrappers-based CCWs

[jkoritzinsky]

To ensure that we get an accurate diagnostics experience for RCWs and CCWs that use the new ComWrappers APIs, we should enlighten the DAC to how to discover them and dump them.

Additionally, this work should include updating the DAC's support for dumping a stowed exception to be able to unwrap ComWrappers-based CCW stowed exceptions.

Related: microsoft/CsWinRT#201, #35318

Tagging subscribers to this area: @tommcdon
Notify danmosemsft if you want to be subscribed.

[jkoritzinsky]

cc: @AaronRobinsonMSFT @tommcdon

[AaronRobinsonMSFT]

@jkoritzinsky Thanks for filing this. Can you elaborate on what information would be helpful? The details that are in the ComWrappers RCW/CCW are vastly different than the built in ones.

[jkoritzinsky]

For the stowed exception scenario in particular, the DAC needs to be able to identity an interface pointer as a ComWrappers CCW interface pointer, retrieve the managed object, and dump the managed object.

The implementations of

runtime/src/coreclr/src/inc/sospriv.idl

Lines 299 to 304 in b48900f

	// COM
	HRESULT GetRCWData(CLRDATA_ADDRESS addr, struct DacpRCWData *data);
	HRESULT GetRCWInterfaces(CLRDATA_ADDRESS rcw, unsigned int count, struct DacpCOMInterfacePointerData *interfaces, unsigned int *pNeeded);
	HRESULT GetCCWData(CLRDATA_ADDRESS ccw, struct DacpCCWData *data);
	HRESULT GetCCWInterfaces(CLRDATA_ADDRESS ccw, unsigned int count, struct DacpCOMInterfacePointerData *interfaces, unsigned int *pNeeded);
	HRESULT TraverseRCWCleanupList(CLRDATA_ADDRESS cleanupListPtr, VISITRCWFORCLEANUP pCallback, LPVOID token);

are what we need to enlighten.

In particular, GetCCWData at

runtime/src/coreclr/src/debug/daccess/request.cpp

Line 4069 in b48900f

HRESULT ClrDataAccess::GetCCWData(CLRDATA_ADDRESS ccw, struct DacpCCWData *ccwData)

is the function that the "dump stowed exception" path uses to unwrap the stowed exception object and get the information for the user.

[jkoritzinsky]

If we implement all of the mentioned functions for the DAC, I think that will enable all of the CCW/RCW related SOS commands for ComWrappers CCWs and RCWs as well.

[AaronRobinsonMSFT]

This is going to be unfortunate. I was hoping to avoid having a DAC build of the interoplib. We might want to redesign some of the data structures so the header contains everything. Don't know if that has already been done.

[tommcdon]

@noahfalk