Skip to content

Ensure we can run the not-supported source generation in source build #41042

Description

@ericstj

Follow up issue for #33631

We should remove this file as it should no longer be needed: https://github.com/dotnet/runtime/blob/master/eng/notSupported.SourceBuild.targets

We should also change the condition on

<PackageReference Include="Microsoft.DotNet.GenAPI" Condition="'$(DotNetBuildOffline)' != 'true'" Version="$(MicrosoftDotNetGenApiVersion)" PrivateAssets="all" IsImplicitlyDefined="true" />
to

    <PackageReference Include="Microsoft.DotNet.GenAPI" Condition="'$(DotNetBuildFromSource)' != 'true'" Version="$(MicrosoftDotNetGenApiVersion)" PrivateAssets="all" IsImplicitlyDefined="true" />

While doing this, review the original changes that added this behavior to ensure there are no other places that need to be cleaned up.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions