[Perf] Regressions in IndexOf

[DrewScoggins]

Run Information

Architecture	x64
OS	Windows 10.0.18362
Baseline	4a73cb9af55814e26b78f22d30bd35faa60c31a3
Compare	6ab1cee00ba41b308009c88864aba46b0f61f061
Diff	Diff

Regressions in System.Globalization.Tests.StringSearch

Benchmark	Baseline	Test	Test/Base	Test Quality	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
LastIndexOf_Word_NotFound - Duration of single invocation	556.53 ns	592.84 ns	1.07	0.01
LastIndexOf_Word_NotFound - Duration of single invocation	556.77 ns	592.91 ns	1.06	0.00
IndexOf_Word_NotFound - Duration of single invocation	560.81 ns	594.70 ns	1.06	0.00
LastIndexOf_Word_NotFound - Duration of single invocation	556.54 ns	590.50 ns	1.06	0.00
IndexOf_Word_NotFound - Duration of single invocation	560.67 ns	596.84 ns	1.06	0.00
IndexOf_Word_NotFound - Duration of single invocation	560.08 ns	596.92 ns	1.07	0.00

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Globalization.Tests.StringSearch*'

Details

Payloads

Baseline
Compare

Histogram

System.Globalization.Tests.StringSearch.LastIndexOf_Word_NotFound(Options: (en-US, IgnoreNonSpace, False))

System.Globalization.Tests.StringSearch.LastIndexOf_Word_NotFound(Options: (en-US, None, False))

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (, None, False))

System.Globalization.Tests.StringSearch.LastIndexOf_Word_NotFound(Options: (, None, False))

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (en-US, IgnoreNonSpace, False))

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (en-US, None, False))

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information

Architecture	x64
OS	Windows 10.0.18362
Baseline	4a73cb9af55814e26b78f22d30bd35faa60c31a3
Compare	6ab1cee00ba41b308009c88864aba46b0f61f061
Diff	Diff

Regressions in System.Memory.ReadOnlySpan

Benchmark	Baseline	Test	Test/Base	Test Quality	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
IndexOfString - Duration of single invocation	231.36 ns	245.69 ns	1.06	0.00

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Memory.ReadOnlySpan*'

Details

Payloads

Baseline
Compare

Histogram

System.Memory.ReadOnlySpan.IndexOfString(input: "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAXAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", value: "x", comparisonType: InvariantCultureIgnoreCase)

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Tagging subscribers to this area: @tarekgh, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Run Information

Architecture	x64
OS	Windows 10.0.18362
Baseline	4a73cb9af55814e26b78f22d30bd35faa60c31a3
Compare	6ab1cee00ba41b308009c88864aba46b0f61f061
Diff	Diff

Regressions in System.Globalization.Tests.StringSearch

Benchmark	Baseline	Test	Test/Base	Test Quality	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
LastIndexOf_Word_NotFound - Duration of single invocation	556.53 ns	592.84 ns	1.07	0.01
LastIndexOf_Word_NotFound - Duration of single invocation	556.77 ns	592.91 ns	1.06	0.00
IndexOf_Word_NotFound - Duration of single invocation	560.81 ns	594.70 ns	1.06	0.00
LastIndexOf_Word_NotFound - Duration of single invocation	556.54 ns	590.50 ns	1.06	0.00
IndexOf_Word_NotFound - Duration of single invocation	560.67 ns	596.84 ns	1.06	0.00
IndexOf_Word_NotFound - Duration of single invocation	560.08 ns	596.92 ns	1.07	0.00

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Globalization.Tests.StringSearch*'

Details

Payloads

Baseline
Compare

Histogram

System.Globalization.Tests.StringSearch.LastIndexOf_Word_NotFound(Options: (en-US, IgnoreNonSpace, False))

System.Globalization.Tests.StringSearch.LastIndexOf_Word_NotFound(Options: (en-US, None, False))

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (, None, False))

System.Globalization.Tests.StringSearch.LastIndexOf_Word_NotFound(Options: (, None, False))

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (en-US, IgnoreNonSpace, False))

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (en-US, None, False))

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information

Architecture	x64
OS	Windows 10.0.18362
Baseline	4a73cb9af55814e26b78f22d30bd35faa60c31a3
Compare	6ab1cee00ba41b308009c88864aba46b0f61f061
Diff	Diff

Regressions in System.Memory.ReadOnlySpan

Benchmark	Baseline	Test	Test/Base	Test Quality	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
IndexOfString - Duration of single invocation	231.36 ns	245.69 ns	1.06	0.00

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Memory.ReadOnlySpan*'

Details

Payloads

Baseline
Compare

Histogram

System.Memory.ReadOnlySpan.IndexOfString(input: "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAXAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", value: "x", comparisonType: InvariantCultureIgnoreCase)

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author:	DrewScoggins
Assignees:	-
Labels:	arch-x64, area-System.Globalization, os-windows, tenet-performance, tenet-performance-benchmarks, untriaged
Milestone:	-

[tarekgh]

@EgorBo @kunalspathak, I have looked at the merged commits around the regression time, I am not seeing anything can be related to cause this issue except the following two commits:

commit 8868e97a3e69f43e7e97f1b7da463185de9300bf
Author: Kunal Pathak <Kunal.Pathak@microsoft.com>
Date:   Wed May 19 10:01:26 2021 +0530

    Refactor LSRA's heuristics selection (#52832)


commit 0e1adc01d16393c0212c389580e1b788caae5b03
Author: Egor Bogatov <egorbo@gmail.com>
Date:   Wed May 19 09:15:32 2021 +0300

    JIT: Convert some of the old-style intrinsics to NamedIntrinsics (#52156)

We don't have any code globalization code changes at all around that time. Could you please have a look?

CC @jkotas

[kunalspathak]

It seems to be coming from #52827 - @AndyAyersMS