[release/8.0-staging] crashinfo.cpp/crashinfounix.cpp: use off_t instead of off64_t#101272
Merged
jkoritzinsky merged 1 commit intoApr 23, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @tommcdon |
mikem8361
approved these changes
Apr 19, 2024
jeffschwMSFT
approved these changes
Apr 19, 2024
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
lgtm. we will take for consideration in 8.0.x
jkoritzinsky
force-pushed
the
backport/pr-91968-to-release/8.0-staging
branch
from
April 19, 2024 17:15
920e13a to
05ad51a
Compare
jkoritzinsky
force-pushed
the
backport/pr-91968-to-release/8.0-staging
branch
from
April 19, 2024 17:32
05ad51a to
1be7e43
Compare
Member
|
This is no longer blocking servicing as we have a PR with a source-build patch out at dotnet/installer#19544 |
4 tasks
Member
|
please ensure that this is merged, as it has already been merged into release/8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #91968 to release/8.0-staging
/cc @jkoritzinsky @ayakael
Customer Impact
Source-Build's Alpine validation has moved to 3.19, which does not define
off64_t. This fix is required to unblock May servicing. Discovered in dotnet/source-build#4339Regression
Testing
I've manually verified that the images we build against define
off_tas a 64-bit type on 64-bit systems.Risk
Low