JIT: Clean up FlowGraphDominatorTree::Build#103803
Merged
Merged
Conversation
We guarantee that `fgFirstBB` dominates all reachable basic blocks, so `IntersectDom` is never going to end up seeing a `nullptr`. Also, if the DFS tree does not have cycles the algorithm will converge in one iteration, so there is no reason to run a second one to notice no changes. I don't expect much TP improvement from this, but overall I think making use of these assumptions amounts to a clean up.
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
marked this pull request as ready for review
June 21, 2024 14:03
Member
Author
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS No diffs, some minor TP improvements. |
AndyAyersMS
approved these changes
Jun 21, 2024
rzikm
pushed a commit
to rzikm/dotnet-runtime
that referenced
this pull request
Jun 24, 2024
We guarantee that `fgFirstBB` dominates all reachable basic blocks, so `IntersectDom` is never going to end up seeing a `nullptr`. Also, if the DFS tree does not have cycles the algorithm will converge in one iteration, so there is no reason to run a second one to notice no changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We guarantee that
fgFirstBBdominates all reachable basic blocks, soIntersectDomis never going to end up seeing anullptr. Also, if the DFS tree does not have cycles the algorithm will converge in one iteration, so there is no reason to run a second one to notice no changes.I don't expect much TP improvement from this, but overall I think making use of these assumptions amounts to a clean up.