Get ThreadContext for AVX registers - #104514
Merged
janvorli merged 10 commits intoJul 9, 2024
Merged
Conversation
mikelle-rogers
marked this pull request as ready for review
July 6, 2024 20:46
jkotas
reviewed
Jul 7, 2024
jkotas
reviewed
Jul 7, 2024
mikelle-rogers
commented
Jul 8, 2024
Member
|
The shape of the change looks good to me now. It will defer to @janvorli to signoff. |
matouskozak
added a commit
to matouskozak/runtime
that referenced
this pull request
Jul 11, 2024
This reverts commit 5b5d791.
Member
|
/azp backport to release/8.0-staging |
Member
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9912412663 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MachExceptionInfo constructor, update the AVX registers using thread_get_state.
This fixes #78991.
We found that the null reference exception happened because we were not updating the upper half of the ymm register in the MachExceptionInfo. This caused only part of a structure to be copied from the ymm register to a new location. Instead of the second half of the structure in the new location, there were zeros.