Skip to content

[WASI] add trailing header support to WasiHTTPHandler - #109840

Closed
dicej wants to merge 1 commit into
dotnet:mainfrom
dicej:wasi-trailing-headers
Closed

[WASI] add trailing header support to WasiHTTPHandler#109840
dicej wants to merge 1 commit into
dotnet:mainfrom
dicej:wasi-trailing-headers

Conversation

@dicej

@dicej dicej commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@dicej
[WASI] add trailing header support to WasiHTTPHandler
eed10d6 
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@ghost ghost added the area-System.Net.Http label Nov 14, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Nov 14, 2024
dicej added a commit to dicej/runtimelab that referenced this pull request Nov 14, 2024
@dicej
[NativeAOT-LLVM] update Wasmtime version
37bbacf 
v26.0.1 includes bytecodealliance/wasmtime#9208, which
came up while implementing dotnet/runtime#109840

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This was referenced Nov 14, 2024
Merged
Closed
This was referenced Nov 14, 2024
Open
Closed
Closed
jkotas pushed a commit to dotnet/runtimelab that referenced this pull request Nov 14, 2024
@dicej
[NativeAOT-LLVM] update Wasmtime version (#2777)
4b76114 
v26.0.1 includes bytecodealliance/wasmtime#9208, which
came up while implementing dotnet/runtime#109840

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@maraf maraf added arch-wasm WebAssembly architecture os-wasi Related to WASI variant of arch-wasm labels Nov 15, 2024
@maraf maraf added this to the 10.0.0 milestone Nov 15, 2024
@dotnet-policy-service

dotnet-policy-service Bot commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara

pavelsavara commented Nov 18, 2024

Copy link
Copy Markdown
Member

Is TE: trailers already supported by wasmtime ? Or we are not blocked by that ?

(My previous PR #107795)

@dicej

dicej commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

Is TE: trailers already supported by wasmtime ? Or we are not blocked by that ?

Yes, good point. I forgot that you need to modify Wasmtime to actually make this work, and also forgot you had opened a PR for this also. I'll close this one too, and we can revisit once the wasi:http spec is clarified with respect to trailers and wasmtime-wasi-http has been updated accordingly.

@dicej dicej closed this Nov 18, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Net.Http community-contribution Indicates that the PR has been added by a community member os-wasi Related to WASI variant of arch-wasm

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dicej @pavelsavara @maraf