Skip to content

Fixed missed case - #110122

Merged
tommcdon merged 2 commits into
dotnet:mainfrom
eterekhin:terekhin/missed-event-type
Dec 16, 2024
Merged

Fixed missed case#110122
tommcdon merged 2 commits into
dotnet:mainfrom
eterekhin:terekhin/missed-event-type

Conversation

@eterekhin

@eterekhin eterekhin commented Nov 24, 2024

Copy link
Copy Markdown
Contributor

@davmason, Hey! Looks like DB_IPCE_SET_ENABLE_CUSTOM_NOTIFICATION_RESULT was missing.

Assert failure(PID 27069 [0x000069bd], Thread: 3422492 [0x34391c]): !"Unknown debugger event type"
File: runtime/src/coreclr/debug/ee/../shared/dbgtransportsession.cpp:2515
Image: runtime/artifacts/bin/coreclr/osx.arm64.Debug/corerun

Assert failure(PID 27068 [0x000069bc], Thread: 3422412 [0x3438cc]): event.type == DB_IPCE_SET_ENABLE_CUSTOM_NOTIFICATION_RESULT
File: runtime/src/coreclr/debug/di/process.cpp:11583
Image:

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Nov 24, 2024
@dotnet-policy-service

dotnet-policy-service Bot commented Nov 24, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@tommcdon tommcdon added this to the 10.0.0 milestone Nov 25, 2024
@tommcdon

tommcdon commented Dec 16, 2024

Copy link
Copy Markdown
Member

@mikelle-rogers would you mind reviewing this PR?

mikelle-rogers
mikelle-rogers approved these changes Dec 16, 2024
View reviewed changes

@mikelle-rogers mikelle-rogers left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you @eterekhin!

@tommcdon
tommcdon merged commit 7c0e257 into dotnet:main Dec 16, 2024
@eterekhin
eterekhin deleted the terekhin/missed-event-type branch December 17, 2024 08:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mikelle-rogers mikelle-rogers mikelle-rogers approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Diagnostics-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@eterekhin @tommcdon @mikelle-rogers