[release/10.0] Limit doublemapper maximum size - #119392
Merged
Merged
Conversation
The double mapping currently sets the maximum size of the double mapped memory to 2TB. However, that causes the runtime to fail to start if there is a rlimit for max file size set to a smaller value. This change fixed the problem by clipping the max double mapped memory size by that rlimit and also uses much more conservative size even without the file size limit set. It is now set to the total amount of physical memory by default and also clipped by the virtual memory rlimit. Close #117819
Even on 32 bit targets, more than 4GB memory may be available.
jkotas
approved these changes
Sep 5, 2025
jeffschwMSFT
approved these changes
Sep 5, 2025
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. please fill out the template. when ready we can merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #119316 to release/10.0
/cc @janvorli
Customer Impact
When a customer sets maximum file size limit on Linux using the
ulimit -f XXXXcommand to a value smaller than 2TB (4GB on 32 bit OS), .NET process fails to start and crashes with SIGXFSZ signal due to the executable allocator in .NET setting maximum size of shared memory for double mapping to 2TB (4GB on 32 bit OS). See issue #117819.Regression
Testing
Local testing app running under a debugger with
ulimit -fset to low valuesRisk
Low, the change causes the maximum size of executable code to be limited by the: