JIT: Unify to instParamLookup and improve GVM test coverage by hez2010 · Pull Request #126947 · dotnet/runtime

hez2010 · 2026-04-15T12:57:47Z

Extracted from #123323. This PR is the first step in splitting the shared GVM devirtualization work.

It does two things:

expands the generic virtual method test coverage so the later enablement PRs have good coverage
refactors devirtualization a bit to replace multiple ad-hoc flags in CORINFO_DEVIRTUALIZATION_INFO with a single instParamLookup

Contributes to #112596

/cc: @jakobbotsch

dotnet-policy-service · 2026-04-15T12:59:15Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Refactors CoreCLR devirtualization metadata to use a unified instParamLookup and expands JIT test coverage for generic virtual method (GVM) scenarios to support follow-on GVM devirtualization work.

Changes:

Add a new GVM-focused runtime lookup/delegate test to broaden devirtualization coverage.
Replace CORINFO_DEVIRTUALIZATION_INFO ad-hoc flags with instParamLookup, and update JIT devirtualization logic to consume it.
Update SuperPMI and the managed JitInterface type definitions/serialization to match the new CORINFO_DEVIRTUALIZATION_INFO shape (plus bump the JIT/EE versioning GUID).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/tests/JIT/Generics/VirtualMethods/generic_virtual_methods.cs	Adds additional GVM/runtime-lookup-related test coverage.
src/coreclr/vm/jitinterface.cpp	Initializes/produces `instParamLookup` for devirtualization results (replacing older flags).
src/coreclr/jit/importercalls.cpp	Plumbs `instParamLookup` through devirtualization + guarded devirtualization candidate tracking and inserts instantiation args when required.
src/coreclr/jit/morph.cpp	Simplifies lookup-tree helpers to take `CORINFO_LOOKUP` directly.
src/coreclr/jit/compiler.h	Updates declarations for the new lookup-tree helper signatures and GDV candidate plumbing.
src/coreclr/inc/corinfo.h	Updates `CORINFO_DEVIRTUALIZATION_INFO` to carry `instParamLookup` instead of legacy flags; documents “no lookup needed” sentinel.
src/coreclr/inc/jiteeversionguid.h	Bumps the JIT/EE version GUID for the interface change.
src/coreclr/tools/Common/JitInterface/CorInfoTypes.cs	Mirrors the `CORINFO_DEVIRTUALIZATION_INFO` layout change in managed definitions.
src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs	Updates managed `resolveVirtualMethod` implementation to populate `instParamLookup` and method-context behavior.
src/coreclr/tools/superpmi/superpmi-shared/agnostic.h	Updates SuperPMI record structs to include `instParamLookup`.
src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp	Records/restores/dumps `instParamLookup` in SuperPMI method contexts.

hez2010 · 2026-04-16T03:28:30Z

Test failure seems unrelated.

hez2010 · 2026-04-24T04:28:04Z

Ping @jakobbotsch

This is a refactor only change which is the prerequisites of the upcoming GVM devirt work, please take a look when you get some time.

MichalPetryka · 2026-04-24T04:32:09Z

@MihuBot

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

hez2010 · 2026-05-23T16:22:03Z

@MihuBot

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

hez2010 · 2026-05-23T16:51:16Z

@MihuBot

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

hez2010 · 2026-05-23T17:10:16Z

Now it's zero diff as expected.

Also CI failures seem unrelated.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/coreclr/jit/importercalls.cpp:1

When transforming a virtual/interface call into a direct call, clearing only GTF_CALL_VIRT_VTABLE may leave other virtual-kind bits set (e.g., interface/stub dispatch kinds). This can misclassify the call later in the pipeline. Prefer clearing the full virtual-kind mask (e.g., GTF_CALL_VIRT_KIND_MASK) before setting the direct-call state.

// Licensed to the .NET Foundation under one or more agreements.

jakobbotsch

LGTM! Thanks for sticking with this.

Extracted from #123323. This PR is the first step in splitting the shared GVM devirtualization work. It does two things: - expands the generic virtual method test coverage so the later enablement PRs have good coverage - refactors devirtualization a bit to replace multiple ad-hoc flags in `CORINFO_DEVIRTUALIZATION_INFO` with a single `instParamLookup` Contributes to #112596

Part 1: add tests and instParamLookup refactor

6120dec

hez2010 requested a review from MichalStrehovsky as a code owner April 15, 2026 12:57

Copilot AI review requested due to automatic review settings April 15, 2026 12:57

github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 15, 2026

Merge branch 'main' into shared-gvm-devirt/1-tests-instparamlookup

007d14f

dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Apr 15, 2026

Copilot started reviewing on behalf of hez2010 April 15, 2026 12:58 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread src/coreclr/vm/jitinterface.cpp

Comment thread src/coreclr/jit/importercalls.cpp Outdated

This was referenced Apr 22, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

browser-wasm linux Release LibraryTests queues timing out #117974

Open

MihuBot mentioned this pull request Apr 24, 2026

[JitDiff X64] [hez2010] JIT: Unify to instParamLookup and improve GVM test c ... MihuBot/runtime-utils#1850

Open

jakobbotsch reviewed Apr 24, 2026

View reviewed changes

Comment thread src/coreclr/inc/corinfo.h Outdated

Copilot AI review requested due to automatic review settings April 25, 2026 11:55

hez2010 force-pushed the shared-gvm-devirt/1-tests-instparamlookup branch from 75dec5b to 4da609f Compare April 25, 2026 11:55

Copilot started reviewing on behalf of hez2010 April 25, 2026 11:56 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread src/tests/JIT/Generics/VirtualMethods/generic_virtual_methods.cs

Comment thread src/coreclr/vm/jitinterface.cpp

Comment thread src/coreclr/jit/importercalls.cpp Outdated

Merge branch 'main' into shared-gvm-devirt/1-tests-instparamlookup

42d5011

hez2010 force-pushed the shared-gvm-devirt/1-tests-instparamlookup branch from 4da609f to 42d5011 Compare April 25, 2026 12:19

Address review feedbacks

e7acb94

Copilot AI review requested due to automatic review settings April 25, 2026 12:35

Copilot started reviewing on behalf of hez2010 April 25, 2026 12:36 View session

jakobbotsch reviewed Apr 25, 2026

View reviewed changes

Comment thread src/coreclr/jit/importercalls.cpp Outdated

Address some issues that causes non-zero diffs.

b9f5fe4

Copilot AI review requested due to automatic review settings May 23, 2026 16:20

Nit

456cb59

MihuBot mentioned this pull request May 23, 2026

[JitDiff X64] [hez2010] JIT: Unify to instParamLookup and improve GVM test c ... MihuBot/runtime-utils#1930

Open

Copilot AI reviewed May 23, 2026

View reviewed changes

Comment thread src/coreclr/jit/importercalls.cpp

Comment thread src/coreclr/jit/indirectcalltransformer.cpp

Comment thread src/coreclr/jit/compiler.h

Comment thread src/tests/JIT/Generics/VirtualMethods/generic_virtual_methods.cs

Fix AV

d02eec1

Copilot AI review requested due to automatic review settings May 23, 2026 16:49

hez2010 force-pushed the shared-gvm-devirt/1-tests-instparamlookup branch from aba164b to d02eec1 Compare May 23, 2026 16:49

MihuBot mentioned this pull request May 23, 2026

[JitDiff X64] [hez2010] JIT: Unify to instParamLookup and improve GVM test c ... MihuBot/runtime-utils#1932

Open

Copilot AI reviewed May 23, 2026

View reviewed changes

Comment thread src/tests/JIT/Generics/VirtualMethods/generic_virtual_methods.cs

Comment thread src/coreclr/jit/compiler.h

build-analysis Bot mentioned this pull request May 23, 2026

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

2 tasks

Merge branch 'main' into shared-gvm-devirt/1-tests-instparamlookup

a04c829

jakobbotsch reviewed May 26, 2026

View reviewed changes

Comment thread src/coreclr/jit/importercalls.cpp

jakobbotsch reviewed May 26, 2026

View reviewed changes

Comment thread src/coreclr/jit/importercalls.cpp Outdated

Remove unused exactContextHandle

ef010d5

Copilot AI review requested due to automatic review settings May 26, 2026 10:24

Copilot AI reviewed May 26, 2026

View reviewed changes

Comment thread src/coreclr/vm/jitinterface.cpp

Comment thread src/coreclr/jit/importercalls.cpp

Comment thread src/coreclr/jit/compiler.h

build-analysis Bot mentioned this pull request May 26, 2026

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886

Open

3 tasks

jakobbotsch reviewed May 28, 2026

View reviewed changes

Comment thread src/coreclr/jit/compiler.h

jakobbotsch reviewed May 28, 2026

View reviewed changes

Comment thread src/coreclr/jit/compiler.h

jakobbotsch reviewed May 28, 2026

View reviewed changes

Comment thread src/coreclr/jit/importercalls.cpp

jakobbotsch approved these changes May 28, 2026

View reviewed changes

jakobbotsch merged commit 54cfeb4 into dotnet:main May 28, 2026
125 of 131 checks passed

dotnet-maestro Bot mentioned this pull request May 29, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#6910

Merged

dotnet-milestone-bot Bot added this to the 11.0-preview6 milestone Jun 17, 2026

github-actions Bot locked and limited conversation to collaborators Jul 18, 2026

Uh oh!

Conversation

hez2010 commented Apr 15, 2026

Uh oh!

dotnet-policy-service Bot commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

hez2010 commented Apr 16, 2026

Uh oh!

hez2010 commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichalPetryka commented Apr 24, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hez2010 commented May 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hez2010 commented May 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

hez2010 commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakobbotsch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hez2010 commented Apr 24, 2026 •

edited

Loading

hez2010 commented May 23, 2026 •

edited

Loading