[Wasm RyuJit] codegen for callfinally#128348
Merged
Merged
Conversation
Implement the codegen needed to call the finally, in the cases where the finally was not inlined and needs to be invoked on a normal try exit.
Contributor
There was a problem hiding this comment.
Pull request overview
Implements WASM RyuJIT codegen for BBJ_CALLFINALLY blocks, replacing the previous NYI_WASM stub. The new code emits an indirect WASM call to the finally funclet, passing SP and FP as pointer arguments, and emits an unreachable for retless calls.
Changes:
- Replace
NYI_WASM("genCallFinally")with real codegen. - Build the finally's WASM function signature (two pointer args, no return) via
getWasmTypeSymbol. - Push SP/FP locals plus a funclet address constant, issue an indirect call, and emit
unreachablewhenBBF_RETLESS_CALLis set.
Member
Author
|
@kg PTAL |
kg
approved these changes
May 19, 2026
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
eiriktsarpalis
pushed a commit
that referenced
this pull request
Jul 15, 2026
Implement the codegen needed to call the finally, in the cases where the finally was not inlined and needs to be invoked on a normal try exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the codegen needed to call the finally, in the cases where the finally was not inlined and needs to be invoked on a normal try exit.