[release/10.0] Update EmsdkPackageVersion to use version from dependency flow#128939
[release/10.0] Update EmsdkPackageVersion to use version from dependency flow#128939akoeplinger wants to merge 1 commit into
Conversation
It got hardcoded a while ago to workaround a build problem. --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> (cherry picked from commit 58f1b03)
There was a problem hiding this comment.
Pull request overview
Backports #128261 to release/10.0 by removing the hardcoded EmsdkPackageVersion and instead deriving it from the dependency flow–managed MicrosoftNETCoreAppRefPackageVersion, keeping the emsdk package version aligned with the runtime versioning used by the branch.
Changes:
- Switch
EmsdkPackageVersionfrom a fixed value (10.0.0) to$(MicrosoftNETCoreAppRefPackageVersion). - Add clarifying comments explaining why these versions are sourced from other dependency-flow properties.
|
let's not merge this yet, I think using |
|
Hi, the code complete date for 10.0.10 (the July 2026 release) is 24 June. Make sure to merge this PR on that date at the latest (or explicitly let me know that I should merge it), or it won't make it into that release. As a reminder, if this is a product change, you also need Tactics approval before merging this PR (test-only or infra-only changes don't require Tactics approval). |
|
Workflow state for the Holistic Review Orchestrator. {
"version": 5,
"last_dispatched_commit": "815fa210268e5839cb3b735f421be8ef3aa5ff31",
"last_dispatched_base_ref": "release/10.0",
"last_dispatched_base_sha": "edfa1d59ccbcccb0b6d485e170fe15f14878556c",
"last_reviewed_commit": "815fa210268e5839cb3b735f421be8ef3aa5ff31",
"last_reviewed_base_ref": "release/10.0",
"last_reviewed_base_sha": "edfa1d59ccbcccb0b6d485e170fe15f14878556c",
"last_recorded_worker_run_id": "29676153094",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "815fa210268e5839cb3b735f421be8ef3aa5ff31",
"review_id": 4730522366
}
]
} |
There was a problem hiding this comment.
Holistic Review
Motivation: This is a clean backport of the merged PR #128261 to release/10.0. The EmsdkPackageVersion was previously hardcoded to 10.0.0 as a workaround for a past build problem. Hardcoding a package version defeats dependency flow (Maestro), so the emsdk package could not be updated automatically and could drift out of sync with the rest of the runtime. This change restores automatic version flow.
Approach: The single-line value change in eng/Versions.props replaces the literal 10.0.0 with $(MicrosoftNETCoreAppRefPackageVersion), which uses runtime version numbers and is fed by dependency flow (defined in eng/Version.Details.props as 10.0.9, backed by the Microsoft.NETCore.App.Ref dependency in Version.Details.xml). Two explanatory comments are added clarifying why the emsdk and emscripten workload versions reuse existing flowed variables (their package IDs contain changing versions). This mirrors the pattern already used one line above for MicrosoftNETRuntimeEmscriptenVersion.
Summary: LGTM. The referenced MicrosoftNETCoreAppRefPackageVersion property is defined and flows correctly on this branch, the change matches the merged source PR, and it is a low-risk, build-infrastructure-only edit with no product code impact. The added comments are accurate and helpful. No actionable findings.
Detailed Findings
None.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 34.9 AIC · ⌖ 10.2 AIC · ⊞ 10K
Backport of #128261 to release/10.0