Force lf line endings for managed source to fix SourceLink PDB checksums#130358
Closed
steveisok wants to merge 1 commit into
Closed
Force lf line endings for managed source to fix SourceLink PDB checksums#130358steveisok wants to merge 1 commit into
steveisok wants to merge 1 commit into
Conversation
Managed source files used .gitattributes 'text', which stores lf blobs but checks out crlf on Windows build agents. The compiler records the crlf source-document checksums in portable PDBs, while SourceLink points at GitHub raw URLs that serve the lf blobs. Strict SourceLink/PDB byte verification then fails for official packages even though the content matches after line-ending normalization. Add eol=lf for .cs/.vb/.fs/.fsx so every checkout (including Windows CI) uses lf, matching the bytes SourceLink serves. Fixes dotnet#129023 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s root .gitattributes to ensure managed source files always use LF line endings in the working tree, making portable PDB source-document checksums consistent with the LF bytes served by SourceLink.
Changes:
- Force
eol=lffor*.cs,*.vb,*.fs, and*.fsxcheckouts (including on Windows agents). - Preserve existing diff configuration for C# (
diff=csharp) while addingeol=lf. - Add an explanatory comment block documenting the SourceLink/PDB checksum rationale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managed source files used .gitattributes 'text', which stores lf blobs but checks out crlf on Windows build agents. The compiler records the crlf source-document checksums in portable PDBs, while SourceLink points at GitHub raw URLs that serve the lf blobs. Strict SourceLink/PDB byte verification then fails for official packages even though the content matches after line-ending normalization.
Add eol=lf for .cs/.vb/.fs/.fsx so every checkout (including Windows CI) uses lf, matching the bytes SourceLink serves.
Contributes to #129023