Add support for inline pinvokes to Wasm Ryujit

[davidwrighton]

• They should always be READYTORUN_FIXUP_PInvokeTarget instead of READYTORUN_FIXUP_IndirectPInvokeTarget
• There is a debug version of JIT_PinvokeEnd which validates that sp == the __stack_pointer global. I believe our codegen will maintain this invariant, so we should be ok to skip resetting the __stack_pointer global before calls to the C++ implementation of JIT_PInvokeEnd
• One detail which is no longer true after this work is merged is that the __stack_pointer global will be set to increasingly unpredictable values during execution. This is not a new phenomena, as it was happening during EH flow, but now it will happen in normal execution flow. Since the interpreter to R2R thunks will reset the stack before we return to any emscripten compiled code, we should be ok with this.

[Copilot]

Pull request overview

This PR changes the Wasm/CoreCLR and ReadyToRun toolchain to enable (or move toward enabling) inlined P/Invoke sequences in Wasm RyuJIT / R2R scenarios, primarily by adjusting how P/Invoke targets are represented in R2R fixups and how the runtime establishes stackwalk state for inlined P/Invokes on Wasm.

Changes:

• Updates Wasm InlinedCallFrame register display logic to derive IP/SP/FP from an R2R stack pointer in the “inlined P/Invoke” case.
• Introduces Wasm implementations/wrappers for JIT_PInvokeBegin/JIT_PInvokeEnd and adjusts fixup handling so Wasm uses READYTORUN_FIXUP_PInvokeTarget (not indirect).
• Gates READYTORUN_FIXUP_IndirectPInvokeTarget handling in the runtime behind HAS_PINVOKE_IMPORT_PRECODE.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File	Description
src/coreclr/vm/wasm/helpers.cpp	Adds Wasm-specific inlined P/Invoke frame setup and stackwalk register-display logic; introduces Wasm JIT_PInvokeBegin/End implementations/wrappers.
src/coreclr/vm/jitinterface.cpp	Wraps READYTORUN_FIXUP_IndirectPInvokeTarget runtime fixup support with HAS_PINVOKE_IMPORT_PRECODE.
src/coreclr/tools/aot/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs	Forces Wasm ReadyToRun compilations to use direct P/Invoke target fixups (and adds explanatory comments).

[dotnet-policy-service]

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

[AndyAyersMS]

Locally I have these ai-supplied fixes on top of this. Think they were also called out above.

1. Rebase glue for  InlinedCallFrame::UpdateRegDisplay_Impl  — adapts Add support for inline pinvokes to Wasm Ryujit #130384's  INLINED_PINVOKE_FROM_R2R  handling to main's current  InlinedCallFrame  field layout: uses  m_pCallerReturnAddress  (dac_cast to  TADDR ) instead of the PR's  m_CallerReturnAddress , and casts  m_pCallSiteSP  into a local.

2. DEBUG  JIT_PInvokeEnd  fix — the debug variant is supposed to validate that R2R codegen kept  sp == __stack_pointer  across the call, but the naked asm was doing  global.set __stack_pointer  (resetting it, like Begin) and passing the wrong arg. Fixed to  global.get  so it reads the current global and passes it as arg2 for the  _ASSERTE(sp == stack_pointer_global_value)  check; also changed  JIT_PInvokeEndImpl  return type from  void*  to  void .

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/coreclr/vm/wasm/helpers.cpp:706

• m_pCallerReturnAddress is being set to the magic value INLINED_PINVOKE_FROM_R2R (1). Other VM code assumes this field is a real code address (e.g., exception unwinding checks ExecutionManager::IsReadyToRunCode(m_pCallerReturnAddress) to decide whether to unlink the frame). With a sentinel value, unwinds will take the wrong path (or potentially probe an invalid PC on other configurations). Prefer storing the actual virtual IP derived from sp (and optionally the derived frame pointer) instead of a sentinel.

    ::new ((void*)pFrame) InlinedCallFrame();
    pFrame->m_pCallSiteSP          = sp;
    pFrame->m_pCallerReturnAddress = INLINED_PINVOKE_FROM_R2R; // When this is true, UpdateRegDisplay_Impl derives state from m_pCallSiteSP.
    pFrame->m_pCalleeSavedFP       = 0;
    pFrame->m_pThread              = pThread;

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.