[release/11.0-preview6] Source code updates from dotnet/dotnet#130387
[release/11.0-preview6] Source code updates from dotnet/dotnet#130387dotnet-maestro[bot] wants to merge 3 commits into
Conversation
Diff: https://github.com/dotnet/dotnet/compare/73e6d95740bd15f942f45e2bd25fe4bcc16fa2b3..2461daa1d76b420ad12e4ebd73e64a4421cc365f From: dotnet/dotnet@73e6d95 To: dotnet/dotnet@2461daa [[ commit created by automation ]]
Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.BannedApiAnalyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.9.0-1.26326.122 -> 5.9.0-1.26357.118) Microsoft.CodeAnalysis.NetAnalyzers, Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-11.0.100.Transport (Version 11.0.100-preview.6.26326.122 -> 11.0.100-preview.6.26357.118) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 11.0.0-beta.26326.122 -> 11.0.0-beta.26357.118) Microsoft.DotNet.Cecil (Version 0.11.5-preview.26326.122 -> 0.11.5-preview.26357.118) Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.26326.122 -> 2.9.3-beta.26357.118) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 11.0.0-preview.6.26326.122 -> 11.0.0-preview.6.26357.118) NuGet.Frameworks, NuGet.Packaging, NuGet.ProjectModel, NuGet.Versioning (Version 7.9.0-rc.32722 -> 7.9.0-rc.35818) System.CommandLine (Version 3.0.0-preview.6.26326.122 -> 3.0.0-preview.6.26357.118) [[ commit created by automation ]]
|
Note VMR PRs included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.BannedApiAnalyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.9.0-1.26357.118 -> 5.9.0-1.26359.118) Microsoft.CodeAnalysis.NetAnalyzers, Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-11.0.100.Transport (Version 11.0.100-preview.6.26357.118 -> 11.0.100-preview.6.26359.118) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 11.0.0-beta.26357.118 -> 11.0.0-beta.26359.118) Microsoft.DotNet.Cecil (Version 0.11.5-preview.26357.118 -> 0.11.5-preview.26359.118) Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.26357.118 -> 2.9.3-beta.26359.118) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 11.0.0-preview.6.26357.118 -> 11.0.0-preview.6.26359.118) NuGet.Frameworks, NuGet.Packaging, NuGet.ProjectModel, NuGet.Versioning (Version 7.9.0-rc.35818 -> 7.9.0-rc.36018) System.CommandLine (Version 3.0.0-preview.6.26357.118 -> 3.0.0-preview.6.26359.118) [[ commit created by automation ]]
|
Workflow state for the Holistic Review Orchestrator. {
"version": 5,
"last_dispatched_commit": "b528b75f58d54dfc26f6556b041257ee683ff72b",
"last_dispatched_base_ref": "release/11.0-preview6",
"last_dispatched_base_sha": "b492b5e130450d177772b3f5388d6abecc9d3608",
"last_reviewed_commit": "b528b75f58d54dfc26f6556b041257ee683ff72b",
"last_reviewed_base_ref": "release/11.0-preview6",
"last_reviewed_base_sha": "b492b5e130450d177772b3f5388d6abecc9d3608",
"last_recorded_worker_run_id": "29680717978",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "b528b75f58d54dfc26f6556b041257ee683ff72b",
"review_id": 4730521523
}
]
} |
There was a problem hiding this comment.
Holistic Review
Motivation: This is an automated Maestro codeflow update for release/11.0-preview6, flowing source and dependency changes from dotnet/dotnet into dotnet/runtime. It bumps Arcade/Helix/SDK/IL toolset versions and the pinned .NET SDK, and carries one source change to the Mono CMake build.
Approach: Three of the four changed files (eng/Version.Details.props, eng/Version.Details.xml, global.json) are mechanical version-string updates produced by the codeflow tooling and are consistent with one another (all moving to the 26359.118 / preview.6 build). The single source change in src/mono/CMakeLists.txt introduces a MONO_LLVM_ENABLED gate: when LLVM_PREFIX is set but the C++ compiler is Clang older than 21.0, it emits a warning and disables Mono's LLVM support instead of attempting to build it.
Summary: The change is low-risk and well-formed. The new gate is correct: MONO_LLVM_ENABLED is only assigned inside if(LLVM_PREFIX), so the subsequent if(MONO_LLVM_ENABLED) block is skipped when LLVM is not requested (unset variable is falsy) and when Clang is too old, preserving the prior if(LLVM_PREFIX) semantics for supported toolchains. The clang-version guard only applies to CMAKE_CXX_COMPILER_ID STREQUAL "Clang", so GCC/MSVC builds are unaffected. One minor behavioral note for awareness (not a blocking issue): on an older-Clang host that previously built with LLVM enabled, LLVM support will now silently downgrade to a warning-only disable rather than failing; this appears intentional given the message wording. No correctness, security, or API concerns. Verdict: LGTM.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 51.6 AIC · ⌖ 10.3 AIC · ⊞ 10K
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos
Diff the source with this PR branch