[ci-fix] Stop dump-doc collection on unsupported Helix targets (refs #131382) - #131515
Open
github-actions[bot] wants to merge 2 commits into
Open
github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
…131382) Android-on-Windows Helix work items (linux-bionic RID on a Windows queue) took the Unix-syntax HelixPostCommand branch even though cmd.exe runs the command, so $HELIX_PYTHONPATH was never expanded and the work item exited 1. Key the gen-debug-dump-docs post-commands off the existing WindowsShell property, which already accounts for that case. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
akoeplinger
reviewed
Jul 29, 2026
This was referenced Jul 29, 2026
This was referenced Aug 29, 2026
Open
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a9666ebc-df24-4bb4-8bad-b779fc37fd52
kotlarmilos
marked this pull request as ready for review
September 14, 2026 12:02
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The critical maccatalyst failure remains unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This pull request fixes Helix dump-document post-command generation by selecting syntax based on the actual shell and omitting unsupported targets.
Changes:
- Uses
WindowsShellfor Windows versus POSIX command syntax. - Skips dump-document collection for Android, browser, and WASI targets.
- Retains commands for supported targets.
File summaries
| File | Summary |
|---|---|
src/libraries/sendtohelixhelp.proj |
Adjusts Helix post-command conditions and shell-specific commands; maccatalyst remains unresolved. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Comment on lines
+271
to
+275
| <HelixPostCommands Condition="'$(WindowsShell)' == 'true' and '$(TargetOS)' != 'android' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'"> | ||
| $(HelixPostCommands); | ||
| %HELIX_PYTHONPATH% %HELIX_CORRELATION_PAYLOAD%\gen-debug-dump-docs.py -buildid $(BUILD_BUILDID) -workitem %HELIX_WORKITEM_FRIENDLYNAME% -jobid %HELIX_CORRELATION_ID% -outdir %HELIX_WORKITEM_UPLOAD_ROOT% -templatedir %HELIX_CORRELATION_PAYLOAD% -dumpdir %HELIX_DUMP_FOLDER% -productver $(ProductVersion) | ||
| </HelixPostCommands> | ||
| <HelixPostCommands Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'"> | ||
| <HelixPostCommands Condition="'$(WindowsShell)' != 'true' and '$(TargetOS)' != 'android' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'"> |
This was referenced Sep 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #131382
Note
This pull request was prepared with GitHub Copilot assistance.
Root cause
Android Helix work items can run on Windows queues. The
gen-debug-dump-docs.pypost-command used POSIX shell syntax becauseTargetOSwasandroid, but the command ran undercmd.exe. The unexpanded$HELIX_PYTHONPATHtoken was treated as a command name and failed after the tests had completed.Fix
Use the existing
WindowsShellproperty to select command syntax for supported targets. Do not add the dump-document post-command for Android, browser, or WASI because dump collection is not supported or useful for those targets.This addresses Alex Koeplinger's review feedback by applying the platform exclusions consistently to both shell branches.
Validation
./build.sh clr+libs -rc release./build.sh libs -rc releaseHelixPostCommandsfor Windows, Linux, Android-on-Windows, browser-on-Windows, and WASI-on-Windows. Windows and Linux retain the expected command. Android, browser, and WASI produce no dump-document command.Evidence
Filed by
ci-failure-fix.