Skip to content

Consolidate libraries Helix submissions - #131971

Merged
agocke merged 2 commits into
dotnet:mainfrom
agocke:remove-library-helix-submit-jobs
Aug 7, 2026
Merged

agocke merged 2 commits into
dotnet:mainfrom
agocke:remove-library-helix-submit-jobs

Conversation

@agocke

@agocke agocke commented Aug 6, 2026

Copy link
Copy Markdown
Member

With the Helix Job Monitor enabled, Helix submissions no longer need dedicated Azure DevOps jobs to wait for test completion.

Move the libraries Helix submissions into the combined CoreCLR/libraries build jobs, where both the runtime and test payloads are already available. This removes 13 artifact-only test-run jobs and avoids publishing and downloading their libraries test artifacts.

The existing platform matrices, Helix queues, path-based submission conditions, runtime configurations, and test-run names are preserved. The shared libraries Helix template now accepts a separate submission configuration for producer jobs whose build configuration differs from the libraries test configuration.

Note

This pull request was prepared with GitHub Copilot.

Submit libraries tests directly from the combined build jobs now that the Helix job monitor tracks completion. Remove the artifact-only test-run jobs and their test artifact transfers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 41511501-4f00-45b6-a59a-e526040dcf58
Copilot AI review requested due to automatic review settings August 6, 2026 21:43
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Consolidates libraries Helix submissions into the combined CoreCLR/libraries build jobs when Helix Job Monitor is enabled, eliminating separate artifact-only test-run jobs and associated artifact publish/download overhead.

Changes:

  • Replaces libraries test artifact uploads with inline Helix submission steps in existing build jobs.
  • Adds path-based change detection variables (librariesContainsChange, coreclrContainsChange) to control Helix submissions.
  • Extends the shared libraries Helix template to allow overriding the Helix MSBuild configuration separately from the producer job’s build configuration.
Show a summary per file
File Description
eng/pipelines/runtime.yml Moves libraries Helix submission into existing build jobs and removes standalone libraries run-test job matrix.
eng/pipelines/libraries/helix.yml Adds helixBuildConfig to decouple Helix /p:Configuration from the producer job build configuration.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 11

Comment thread eng/pipelines/runtime.yml
Comment thread eng/pipelines/runtime.yml
Comment thread eng/pipelines/runtime.yml
Comment thread eng/pipelines/runtime.yml
Comment thread eng/pipelines/runtime.yml
Comment thread eng/pipelines/libraries/helix.yml
Comment thread eng/pipelines/runtime.yml
Comment thread eng/pipelines/runtime.yml
Comment thread eng/pipelines/runtime.yml
Comment thread eng/pipelines/runtime.yml
@jkoritzinsky

Copy link
Copy Markdown
Member

Duplicate of #131948?

@agocke
agocke marked this pull request as ready for review August 6, 2026 22:48
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@agocke

agocke commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

@jkoritzinsky There's overlap, but this one's simpler. I think we can take this one and take that one next.

@jkoritzinsky

Copy link
Copy Markdown
Member

Sounds good.

Mark as contributing to #131615?

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@agocke
agocke disabled auto-merge August 7, 2026 23:43
@agocke
agocke merged commit 4c86c57 into dotnet:main Aug 7, 2026
178 of 180 checks passed
@agocke
agocke deleted the remove-library-helix-submit-jobs branch August 7, 2026 23:43
@github-project-automation github-project-automation Bot moved this to Done in AppModel Aug 7, 2026
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Aug 10, 2026
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
With the Helix Job Monitor enabled, Helix submissions no longer need
dedicated Azure DevOps jobs to wait for test completion.

Move the libraries Helix submissions into the combined CoreCLR/libraries
build jobs, where both the runtime and test payloads are already
available. This removes 13 artifact-only test-run jobs and avoids
publishing and downloading their libraries test artifacts.

The existing platform matrices, Helix queues, path-based submission
conditions, runtime configurations, and test-run names are preserved.
The shared libraries Helix template now accepts a separate submission
configuration for producer jobs whose build configuration differs from
the libraries test configuration.

> [!NOTE]
> This pull request was prepared with GitHub Copilot.

Copilot-Session: 41511501-4f00-45b6-a59a-e526040dcf58
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants