Consolidate libraries Helix submissions - #131971
Conversation
Submit libraries tests directly from the combined build jobs now that the Helix job monitor tracks completion. Remove the artifact-only test-run jobs and their test artifact transfers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 41511501-4f00-45b6-a59a-e526040dcf58
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Consolidates libraries Helix submissions into the combined CoreCLR/libraries build jobs when Helix Job Monitor is enabled, eliminating separate artifact-only test-run jobs and associated artifact publish/download overhead.
Changes:
- Replaces libraries test artifact uploads with inline Helix submission steps in existing build jobs.
- Adds path-based change detection variables (
librariesContainsChange,coreclrContainsChange) to control Helix submissions. - Extends the shared libraries Helix template to allow overriding the Helix MSBuild configuration separately from the producer job’s build configuration.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/runtime.yml | Moves libraries Helix submission into existing build jobs and removes standalone libraries run-test job matrix. |
| eng/pipelines/libraries/helix.yml | Adds helixBuildConfig to decouple Helix /p:Configuration from the producer job build configuration. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 11
|
Duplicate of #131948? |
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
@jkoritzinsky There's overlap, but this one's simpler. I think we can take this one and take that one next. |
|
Sounds good. Mark as contributing to #131615? |
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
With the Helix Job Monitor enabled, Helix submissions no longer need dedicated Azure DevOps jobs to wait for test completion. Move the libraries Helix submissions into the combined CoreCLR/libraries build jobs, where both the runtime and test payloads are already available. This removes 13 artifact-only test-run jobs and avoids publishing and downloading their libraries test artifacts. The existing platform matrices, Helix queues, path-based submission conditions, runtime configurations, and test-run names are preserved. The shared libraries Helix template now accepts a separate submission configuration for producer jobs whose build configuration differs from the libraries test configuration. > [!NOTE] > This pull request was prepared with GitHub Copilot. Copilot-Session: 41511501-4f00-45b6-a59a-e526040dcf58
With the Helix Job Monitor enabled, Helix submissions no longer need dedicated Azure DevOps jobs to wait for test completion.
Move the libraries Helix submissions into the combined CoreCLR/libraries build jobs, where both the runtime and test payloads are already available. This removes 13 artifact-only test-run jobs and avoids publishing and downloading their libraries test artifacts.
The existing platform matrices, Helix queues, path-based submission conditions, runtime configurations, and test-run names are preserved. The shared libraries Helix template now accepts a separate submission configuration for producer jobs whose build configuration differs from the libraries test configuration.
Note
This pull request was prepared with GitHub Copilot.