Skip to content

Limit header name in HtppListenerRequest #132163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iremyux merged 5 commits into from
Aug 14, 2026
Merged

Limit header name in HtppListenerRequest #132163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d09d062
Reject spaces
iremyux Aug 11, 2026
fa6df8d
Change order of test data
iremyux Aug 11, 2026
56c63d0
Check if filed name is a token
iremyux Aug 12, 2026
4555516
Remove ContainsAnyExcept check
iremyux Aug 12, 2026
c08cfc0
Merge branch 'main' into 132128-htpprequest-check
iremyux Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpListenerRequest.Managed.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,15 +208,15 @@ internal void FinishInitialization()
internal void AddHeader(string header)
{
int colon = header.IndexOf(':');
if (colon == -1 || colon == 0)
if (colon <= 0)
{
_context.ErrorMessage = HttpStatusDescription.Get(400);
_context.ErrorStatus = 400;
return;
}

string name = header.AsSpan(0, colon).Trim().ToString();
string val = header.AsSpan(colon + 1).Trim().ToString();
string name = header.AsSpan(0, colon).ToString();
string val = header.AsSpan(colon + 1).Trim(" \t").ToString();
if (name.Equals("content-length", StringComparison.OrdinalIgnoreCase))
{
// To match Windows behavior:
Expand Down
7 changes: 7 additions & 0 deletions src/libraries/System.Net.HttpListener/tests/InvalidClientRequestTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ public static IEnumerable<object[]> InvalidRequest_TestData()
yield return new object[] { "GET {path} HTTP/1.1", null, new string[] { ":" }, null, "Bad Request" };
yield return new object[] { "GET {path} HTTP/1.1", null, new string[] { "\0:value" }, null, "Bad Request" };
yield return new object[] { "GET {path} HTTP/1.1", null, new string[] { "value:\0" }, null, "Bad Request" };
if (Helpers.IsManagedImplementation)
{
yield return new object[] { "GET {path} HTTP/1.1", null, new string[] { " Header: value" }, null, "Bad Request" };
yield return new object[] { "GET {path} HTTP/1.1", null, new string[] { "\tHeader: value" }, null, "Bad Request" };
yield return new object[] { "GET {path} HTTP/1.1", null, new string[] { "Header : value" }, null, "Bad Request" };
yield return new object[] { "GET {path} HTTP/1.1", null, new string[] { "Header\t: value" }, null, "Bad Request" };
}

yield return new object[] { "GET {path} HTTP/1.1", "", null, null, "Bad Request" };
yield return new object[] { "GET {path} HTTP/1.1", "Host: \r\n", null, null, "Bad Request" };
Expand Down
Loading