Expose Composite ML-DSA CNG identifiers - #132353
Merged
PranavSenthilnathan merged 1 commit intoAug 18, 2026
Merged
PranavSenthilnathan merged 1 commit into
PranavSenthilnathan merged 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5676db47-d54b-4946-97ec-7fc0a7392c30
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
PranavSenthilnathan
enabled auto-merge (squash)
August 15, 2026 00:45
PranavSenthilnathan
disabled auto-merge
August 15, 2026 00:45
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes Composite ML-DSA identifiers for Windows CNG by promoting existing internal constants to public CngAlgorithm / CngAlgorithmGroup properties, marked as experimental to align with the PQC API posture.
Changes:
- Make
CngAlgorithm.CompositeMLDsaandCngAlgorithmGroup.CompositeMLDsapublic and annotate them withExperimental(SYSLIB5006). - Update the
System.Security.Cryptographyreference assembly to include the new public properties. - Remove the test-only
CngAlgorithmextension shim now that the identifiers are available publicly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithm.cs | Exposes CompositeMLDsa as a public experimental algorithm identifier. |
| src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithmGroup.cs | Exposes CompositeMLDsa as a public experimental algorithm-group identifier. |
| src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs | Adds the new public properties to the ref contract with Experimental("SYSLIB5006"). |
| src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaTestHelpers.Cng.cs | Removes the internal test-only extension helper; tests now use the public API. |
This was referenced Aug 15, 2026
Open
bartonjs
approved these changes
Aug 15, 2026
Member
Author
|
/ba-g #132336 |
PranavSenthilnathan
deleted the
pranavsenthilnathan-composite-mldsa-cng-apis
branch
August 18, 2026 09:15
artl93
pushed a commit
that referenced
this pull request
Sep 19, 2026
main PR: #132353 # Description Expose the experimental Composite ML-DSA CNG identifiers in .NET 11 RC2. Straight backport; no additional code changes. Stack layer 1/4, targeting `release/11.0`. # Customer Impact Completes the new PQC API surface so callers can use named CNG identifiers instead of provider-specific strings. # Regression No. New APIs. # Testing Windows Release build passed. Full crypto suite: 17,454 total, 1 failed, 407 skipped. The X509 key-file cleanup test failed; its targeted rerun passed all 6 cases. The initial failure's cause is undetermined. Cherry-pick equivalence verified. # Risk Low. Exposes existing identifiers as new experimental APIs without changing the cryptographic implementation. > [!NOTE] > This PR description was generated with GitHub Copilot. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5676db47-d54b-4946-97ec-7fc0a7392c30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130052
Note
This PR description was generated with GitHub Copilot.