Exclude desktop-only Security test from mobile builds - #132467
Closed
davidnguyen-tech wants to merge 1 commit into
Closed
davidnguyen-tech wants to merge 1 commit into
davidnguyen-tech wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c120fa18-835a-418d-ae4c-d5888e699e7c
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Member
Author
|
/azp run runtime Note This pipeline trigger was posted by GitHub Copilot at the user's request. |
Member
Author
|
/azp run runtime-extra-platforms Note This pipeline trigger was posted by GitHub Copilot at the user's request. |
|
No pipelines are associated with this pull request. |
1 similar comment
|
No pipelines are associated with this pull request. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the build condition for System.Net.Security.Unit.Tests so a desktop-only test file (SslAuthenticationOptionsTests.Desktop.cs) is excluded from mobile (and related) build legs, preventing it from being compiled where it can trigger startup failures.
Changes:
- Switch the
SslAuthenticationOptionsTests.Desktop.csCompilecondition fromTargetPlatformIdentifier-based checks toTargetsMobile-based gating. - Ensure tvOS builds (which can build this project as
net11.0-unix) still treat the build as “mobile” for exclusion purposes.
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SslAuthenticationOptionsTests.Desktop.csfrom all mobile buildsTargetsMobilebecause tvOS builds this project asnet11.0-unix, making the previousTargetPlatformIdentifier == 'unix'condition ineffectiveFollow-up to #131922 and #132277.
Validation
./build.sh clr+libs -rc releaseSystem.Net.Security.Unit.Tests: 134 total, 0 failed, 3 skippedSslAuthenticationOptionsTests.Desktop.cscompile inputNote
This pull request was prepared with GitHub Copilot assistance and reviewed by the submitting developer.