Skip to content

Avoid an allocation on every GetOrCreateComInterfaceForObject call #132481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronRobinsonMSFT merged 3 commits into from
Sep 1, 2026
Merged

Avoid an allocation on every GetOrCreateComInterfaceForObject call #132481

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e002b5
Avoid allocating the state for a CCW that already exists
Sergio0694 Aug 18, 2026
d2f7b37
Use fields to reduce metadata
Sergio0694 Aug 18, 2026
0090132
Remove unnecessary docs
Sergio0694 Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,16 +790,22 @@ public unsafe IntPtr GetOrCreateComInterfaceForObject(object instance, CreateCom

ManagedObjectWrapperHolder managedObjectWrapper = _managedObjectWrapperTable.GetOrAdd(instance, static (c, state) =>
{
ManagedObjectWrapper* value = state.This.CreateManagedObjectWrapper(c, state.flags);
ManagedObjectWrapper* value = state.ComWrappers.CreateManagedObjectWrapper(c, state.Flags);
return new ManagedObjectWrapperHolder(value, c);
}, new { This = this, flags });
}, new CreateManagedObjectWrapperState(this, flags));

managedObjectWrapper.AddRef();
RegisterManagedObjectWrapperForDiagnostics(instance, managedObjectWrapper);

return managedObjectWrapper.ComIp;
}

private readonly struct CreateManagedObjectWrapperState(ComWrappers comWrappers, CreateComInterfaceFlags flags)
{
public readonly ComWrappers ComWrappers = comWrappers;
public readonly CreateComInterfaceFlags Flags = flags;
}

private static void RegisterManagedObjectWrapperForDiagnostics(object instance, ManagedObjectWrapperHolder wrapper)
{
if (!Debugger.IsSupported)
Expand Down
Loading