[release/10.0] Fix crossgen2 rejecting input files with uppercase .DLL/.EXE extensions - #132895
Merged
Merged
Conversation
…ns (#132857) `crossgen2` rejected input assemblies whose on-disk extension is uppercase (`.DLL`/`.EXE`), which occurs on filesystems/network shares that normalize casing (e.g. WinFsp/virtiofs). This is a regression from `Microsoft.NETCore.App.Crossgen2` 10.0.5 → 10.0.9, breaking `PublishReadyToRun` builds on affected volumes. ## Root Cause `RunSingleCompilation` in `src/coreclr/tools/aot/crossgen2/Program.cs` matched `Path.GetExtension(inFilePath)` against `.dll`/`.exe` using a case-sensitive switch expression, throwing `CommandLineException` for any other casing. ## Fix - Replaced the switch expression with cascading `if`/`else if` statements comparing the extension via `StringComparison.OrdinalIgnoreCase`, so `.dll`, `.DLL`, `.Dll`, `.exe`, `.EXE`, etc. are all accepted. - Fixes #132554 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
jkoritzinsky
approved these changes
Sep 4, 2026
Member
|
/ba-g all test failures are known |
agocke
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #132857 to release/10.0
/cc @jtschuster @copilot
Customer Impact
Crossgen2 does not accept uppercase letters as the file extension for .dll and .exe files. On filesystems that always report uppercase file names, this makes it impossible to use the affected versions of crossgen2.
Regression
Introduced between 10.0.5 and 10.0.9 of
Microsoft.NETCore.App.Crossgen2.win-x64, likely e0f8bcbTesting
Testing was validated with a local build of crossgen2.
Risk
Low. The change is small and targeted, and no existing tests have failed.