Use project references for shared framework pack inputs by jkoritzinsky · Pull Request #133115 · dotnet/runtime

jkoritzinsky · 2026-09-02T17:31:43Z

Summary

derive Microsoft.NETCore.App managed library and generator inputs from NetCoreAppLibrary.props through project references
preserve shared-framework shims such as mscorlib and the existing analyzer package layout
rebuild libs.native through build-native.proj before liveBuilds.targets harvests native files, while deduplicating combined libs.native+packs builds

Validation

built CoreCLR, Mono, and NativeAOT product packs
built libs.native+packs.product and confirmed one build-native.proj execution
generated the runtime zip and tar.gz archives through the bundle archive target
confirmed reference packages are byte-identical, runtime package inventories are unchanged, and zip/tar payloads match

Note

This PR description was generated by GitHub Copilot.

Derive managed shared framework and generator inputs from NetCoreAppLibrary.props, and rebuild native library inputs through build-native.proj before packaging. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a02d8ce4-72ef-40df-b3d2-8bea5d31d7a4

azure-pipelines · 2026-09-02T17:32:24Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-09-02T17:33:04Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Copilot

Copilot review overview

🔵 Needs a closer look

It changes core packaging/build-graph mechanics across multiple MSBuild entry points, so a maintainer should validate the end-to-end pack composition and build ordering implications.

Review tier: Lite
Findings: 1

New issues introduced by this change (1)

Severity	Finding
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj` — The generator projects are multi-targeted (e.g., netstandard2.0 +…

What changed in this PR

This PR refactors how the shared-framework (SFX) packs discover their managed-library and generator inputs by deriving them from NetCoreAppLibrary.props via project references, and adjusts the build graph so libs.native is built before native files are harvested for packs.

Changes:

Replace ad-hoc project globbing in sfx-src.proj / sfx-gen.proj with a shared NetCoreAppLibraryProjectReferences.props import that produces the project reference item lists.
Update Microsoft.NETCore.App runtime/ref pack projects to consume managed library outputs (and generator analyzer files) via project references/MSBuild harvesting instead of local-build artifact globbing.
Split eng/liveBuilds.targets runtime file harvesting into managed vs native targets and tweak subset build properties to ensure correct runtime-flavor propagation and avoid duplicate build-native.proj executions.

File	Description
src/libraries/sfx-src.proj	Switch traversal inputs to `@(NetCoreAppLibrarySourceProject)` from the shared props import.
src/libraries/sfx-gen.proj	Switch traversal inputs to `@(NetCoreAppLibraryGeneratorProject)` from the shared props import.
src/libraries/NetCoreAppLibraryProjectReferences.props	New shared logic to compute library/generator ProjectReference item lists (incl. shim validation).
src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.props	Add project references to `build-native.proj` and `sfx-src.proj`; derive runtime assemblies from resolved project outputs.
src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj	Use resolved project outputs for WASM framework R2R inputs and move `-r` closure to a response file.
src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj	Derive reference/doc inputs from resolved project outputs and harvest analyzer files via `GetAnalyzerPackFiles`.
eng/Subsets.props	Pass runtime-flavor properties through subset build items (including `libs.native` and pack builds).
eng/liveBuilds.targets	Separate managed vs native library runtime harvesting and recompose `ResolveLibrariesRuntimeFilesFromLocalBuild`.

Avoid building every target framework for generator project references while preserving the existing ref pack analyzer layout. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a02d8ce4-72ef-40df-b3d2-8bea5d31d7a4

Copilot

Copilot review overview

🟡 Changes recommended

The new native-artifact existence enforcement in ResolveLibrariesRuntimeFilesFromLocalBuild risks breaking existing managed-only consumers unless they’re updated to use the new managed-only target (or the enforcement is made opt-in).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1

New issues introduced by this change (1)

Severity	Finding
	`eng/liveBuilds.targets` — EnsureLocalLibrariesNativeArtifactsExist now hard-errors when $(LibrariesNativeArtifactsPath)…

Issues resolved since last review (1)

Severity	Finding
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj` — The generator projects are multi-targeted (e.g., netstandard2.0 +… View resolved comment

Use the generator project references to collect analyzer files and preserve no-build and Visual Studio packing from existing outputs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a02d8ce4-72ef-40df-b3d2-8bea5d31d7a4

Copilot

Copilot review overview

🟡 Changes recommended

The ref-pack analyzer packaging currently hardcodes the analyzer target path and can break the existing analyzer folder layout (e.g., Roslyn-versioned paths) by ignoring PackagePath.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1 · 1

New issues introduced by this change (1)

Severity	Finding
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj` — The analyzer packaging path is currently hardcoded to `analyzers/dotnet/cs/%(...Culture)` for…

Pre-existing issues (1)

Severity	Finding
	`eng/liveBuilds.targets` — EnsureLocalLibrariesNativeArtifactsExist now hard-errors when $(LibrariesNativeArtifactsPath)… View comment

Derive generator assemblies, symbols, and resources uniformly from project reference target paths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a02d8ce4-72ef-40df-b3d2-8bea5d31d7a4

Copilot

Copilot review overview

🟡 Changes recommended

The ref pack now hardcodes analyzer TargetPath placement, which risks diverging from the existing GeneratorProjectBaseTargetPath-driven analyzer layout used elsewhere.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1 · 1

New issues introduced by this change (1)

Severity	Finding
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj` — The analyzer/generator files are being packed to a hardcoded `analyzers/dotnet/cs/` path. Elsewhere…

Pre-existing issues (1)

Severity	Finding
	`eng/liveBuilds.targets` — EnsureLocalLibrariesNativeArtifactsExist now hard-errors when $(LibrariesNativeArtifactsPath)… View comment

Issues resolved since last review (1)

Severity	Finding
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj` — The analyzer packaging path is currently hardcoded to `analyzers/dotnet/cs/%(...Culture)` for… View resolved comment

Avoid requiring libs.native artifacts for NativeAOT tracing references and WebAssembly P/Invoke table generation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a02d8ce4-72ef-40df-b3d2-8bea5d31d7a4

Copilot

Copilot review overview

🔵 Needs a closer look

It changes core build/packaging dependency flow across multiple MSBuild entrypoints (packs, live builds, wasm/NativeAOT test hooks), so it should be validated by a maintainer with CI results before approval.

Review tier: Lite
Findings: 1

Pre-existing issues (1)

Severity	Finding
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj` — The analyzer/generator files are being packed to a hardcoded `analyzers/dotnet/cs/` path. Elsewhere… View comment

Issues resolved since last review (1)

Severity	Finding
	`eng/liveBuilds.targets` — EnsureLocalLibrariesNativeArtifactsExist now hard-errors when $(LibrariesNativeArtifactsPath)… View resolved comment

Build CoreLib and NativeAOT managed assemblies through project references, extract MIBc merging into a dedicated producer, and let shared framework R2R process CoreLib consistently. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a02d8ce4-72ef-40df-b3d2-8bea5d31d7a4

Copilot

Copilot review overview

🔵 Needs a closer look

It makes broad, cross-cutting changes to build/pack orchestration (project references, artifact resolution, and MIBc production) that warrant final human review for packaging/layout and build graph regressions.

Review tier: Lite
Findings: 1 · 2

New issues introduced by this change (2)

Severity	Finding
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj` — Remove the empty <ItemGroup> block; it doesn't carry any items and makes the project file harder to…
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.Mono.sfxproj` — Remove the empty <ItemGroup> block; it adds noise and can mislead readers into thinking project…

Pre-existing issues (1)

Severity	Finding
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj` — The satellite resource assembly glob uses `*\...` which does not populate `%(RecursiveDir)`. As a… View comment

Use a recursive generator resource glob and remove empty runtime pack item groups. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a02d8ce4-72ef-40df-b3d2-8bea5d31d7a4

Copilot

Copilot review overview

🔵 Needs a closer look

eng/codeOptimization.targets can enable PGO embedding while producing no .mibc input when UseMibcProjectReference is disabled, which risks invalid/ineffective R2R compilation settings.

Review tier: Lite
Findings: None

Issues resolved since last review (3)

Severity	Finding
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.Mono.sfxproj` — Remove the empty <ItemGroup> block; it adds noise and can mislead readers into thinking project… View resolved comment
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj` — Remove the empty <ItemGroup> block; it doesn't carry any items and makes the project file harder to… View resolved comment
	`src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj` — The satellite resource assembly glob uses `*\...` which does not populate `%(RecursiveDir)`. As a… View resolved comment

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

eng/codeOptimization.targets:55

In AddReadyToRunPgoOptions, PublishReadyToRunPgoFiles is now sourced only from @(MergedMibcFile). If someone disables UseMibcProjectReference (or it's false in a given build), IncludeMibcFilesInReadyToRun can still become true, which will enable PGO embedding flags but provide no .mibc input file. Consider adding a fallback to the traditional StandardOptimizationData.mibc path when UseMibcProjectReference != true, or otherwise gating PGO inputs on that switch.

Let all runtime packs rely on the condition in codeOptimization.targets instead of forcing the project reference locally. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a02d8ce4-72ef-40df-b3d2-8bea5d31d7a4

Copilot

Copilot review overview

🟡 Changes recommended

Three unresolved findings remain, including one critical packaging issue.

Get a fresh assessment by requesting another Copilot review.

Review tier: Lite
Findings: 1 · 1

Open findings (2)

Keep CoreLib in the runtime pack native layout · New
NativeAOT pack no longer packages merged MIBC · New

Previously missed findings (1)

In code that hasn't changed since last review

CoreCLR runtime pack drops CoreLib symbol files

src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj:62

When UseRuntimeManagedProjectReferences is true, eng/liveBuilds.targets removes the old CoreCLRArtifactsPdbDir entries for System.Private.CoreLib.pdb and System.Private.CoreLib.ni.pdb, so this target must add them. _RuntimeCoreLibFile is only the project output and does not include those separately located PDBs; as written, CoreCLR runtime packs lose these symbols compared with the artifact-based path. Include the existing CoreCLR PDB files alongside the project output before packaging.

Treat project-produced CoreLib as a native runtime-pack asset on every platform and include the merged MIBc project output in regular NativeAOT packs while keeping source-build excluded. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a02d8ce4-72ef-40df-b3d2-8bea5d31d7a4

Copilot

Copilot review overview

🟡 Changes recommended

Artifact override handling and CoreCLR symbol/MIBC packaging gaps remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Preserve supported live artifact path overrides · New

Resolved since last review (2)

Keep CoreLib in the runtime pack native layout
NativeAOT pack no longer packages merged MIBC

Previously missed (1)

In code that hasn't changed since last review

Preserve CoreLib PDBs in project-reference runtime packs

src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj:63

With UseRuntimeManagedProjectReferences=true, this is now the only place that adds CoreCLR's managed CoreLib to RuntimeFiles, but it adds only the DLL. src/coreclr/Directory.Build.targets:6-15 moves the CoreLib PDB to $(RuntimeBinDir)PDB, and the old eng/liveBuilds.targets:123-128 included both System.Private.CoreLib.pdb and System.Private.CoreLib.ni.pdb; symbol-enabled CoreCLR runtime packs therefore omit those files. Add the existing PDB paths, when present, as native RuntimeFiles alongside the DLL.

@@ -1,19 +1,7 @@
 <Project>
-  <!-- Accept override paths for live artifacts. -->
+  <!-- Set up live asset paths. -->


Copilot AI lite review requested due to automatic review settings September 2, 2026 17:31

github-actions Bot added the area-Infrastructure-libraries label Sep 2, 2026

dotnet-policy-service Bot assigned jkoritzinsky Sep 2, 2026

github-project-automation Bot added this to AppModel Sep 2, 2026

Copilot started reviewing on behalf of jkoritzinsky September 2, 2026 17:32 View session

Copilot AI reviewed Sep 2, 2026

View reviewed changes

Comment thread src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj Outdated

Copilot AI review requested due to automatic review settings September 2, 2026 20:53

Copilot started reviewing on behalf of jkoritzinsky September 2, 2026 20:53 View session

Copilot AI reviewed Sep 2, 2026

View reviewed changes

Comment thread eng/liveBuilds.targets

Copilot AI review requested due to automatic review settings September 2, 2026 22:49

Copilot started reviewing on behalf of jkoritzinsky September 2, 2026 22:50 View session

Copilot AI reviewed Sep 2, 2026

View reviewed changes

Comment thread src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj Outdated

Use generator target paths for ref pack

53d9de8

Derive generator assemblies, symbols, and resources uniformly from project reference target paths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a02d8ce4-72ef-40df-b3d2-8bea5d31d7a4

Copilot AI review requested due to automatic review settings September 3, 2026 17:53

Copilot started reviewing on behalf of jkoritzinsky September 3, 2026 17:54 View session

Copilot AI reviewed Sep 3, 2026

View reviewed changes

Comment thread src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj

Copilot AI review requested due to automatic review settings September 3, 2026 19:04

jkoritzinsky requested review from lewing and pavelsavara as code owners September 3, 2026 19:04

Copilot started reviewing on behalf of jkoritzinsky September 3, 2026 19:04 View session

Copilot AI reviewed Sep 3, 2026

View reviewed changes

jkoritzinsky requested a review from sbomer September 3, 2026 22:42

This was referenced Sep 4, 2026

Test Failure: System.Net.WebSockets.Client.Tests.CancelTest_SharedHandler_Loopback.ConnectAsync_Cancel_ThrowsCancellationException #130439

Open

Test failure: GC/Features/HeapExpansion/bestfit-finalize/bestfit-finalize.cmd #132107

Open

lewing requested review from maraf and radekdoulik September 5, 2026 16:47

Copilot AI review requested due to automatic review settings September 9, 2026 01:18

Copilot started reviewing on behalf of jkoritzinsky September 9, 2026 01:19 View session

Copilot AI reviewed Sep 9, 2026

View reviewed changes

Comment thread src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj Outdated

Comment thread src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.Mono.sfxproj Outdated

Preserve analyzer resource directories

397d037

Use a recursive generator resource glob and remove empty runtime pack item groups. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a02d8ce4-72ef-40df-b3d2-8bea5d31d7a4

Copilot AI review requested due to automatic review settings September 9, 2026 04:03

Copilot started reviewing on behalf of jkoritzinsky September 9, 2026 04:04 View session

Copilot AI reviewed Sep 9, 2026

View reviewed changes

build-analysis Bot mentioned this pull request Sep 9, 2026

HttpMetricsTest_Http20.TimeInQueue_RecordedForNewConnectionsOnly test failure #122522

Open

Copilot AI review requested due to automatic review settings September 14, 2026 18:06

Copilot started reviewing on behalf of jkoritzinsky September 14, 2026 18:07 View session

Copilot AI reviewed Sep 14, 2026

View reviewed changes

Comment thread src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj Outdated

Comment thread src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.NativeAOT.sfxproj

Copilot AI review requested due to automatic review settings September 17, 2026 18:12

Copilot started reviewing on behalf of jkoritzinsky September 17, 2026 18:12 View session

Copilot AI reviewed Sep 17, 2026

View reviewed changes

Comment thread eng/liveBuilds.targets

@@ -1,19 +1,7 @@

<Project>

build-analysis Bot mentioned this pull request Sep 18, 2026

XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796

Open

Conversation

jkoritzinsky commented Sep 2, 2026

Summary

Validation

Uh oh!

azure-pipelines Bot commented Sep 2, 2026

Uh oh!

dotnet-policy-service Bot commented Sep 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants