Skip to content

JIT: Tail-merge fix self-loop handling - #133138

Merged
EgorBo merged 4 commits into
dotnet:mainfrom
BoyBaykiller:tail-merge-handle-self-loops-correctly
Sep 9, 2026
Merged

EgorBo merged 4 commits into
dotnet:mainfrom
BoyBaykiller:tail-merge-handle-self-loops-correctly

Conversation

@BoyBaykiller

Copy link
Copy Markdown
Contributor

Fixes #133131

… sense and avoids trying to delete commSucc (which happens to be a silent assumption the caller makes)

* move 'if (predBlock->isEmpty())' check down to when the stmt was inserted (fixes an issue where predBlock==commSuc)
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Sep 3, 2026
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 3, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@BoyBaykiller
BoyBaykiller marked this pull request as ready for review September 3, 2026 03:31
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@AndyAyersMS

Copy link
Copy Markdown
Member

Can you add the issue examples as a regression test case?

@AndyAyersMS AndyAyersMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@AndyAyersMS

Copy link
Copy Markdown
Member

@EgorBo PTAL for secondary review

@AndyAyersMS

Copy link
Copy Markdown
Member

@EgorBo ping (2nd review for ext. contributor pr)

@EgorBo

EgorBo commented Sep 9, 2026

Copy link
Copy Markdown
Member

/ba-g unrelated Runtime_117566 test failure (infra?)

@EgorBo
EgorBo enabled auto-merge (squash) September 9, 2026 00:09
@EgorBo
EgorBo merged commit ef1850b into dotnet:main Sep 9, 2026
141 of 143 checks passed
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JIT: fgHeadTailMerge can remove the block its Blocks() cursor is standing on

3 participants