Address Wasm unboxing stub review feedback - #133461
Merged
davidwrighton merged 1 commit intoSep 9, 2026
Merged
Conversation
Use the standard VM contract and keep the generated unboxing stub typed as void* through lookup and return. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped, preserves the underlying lookup behavior (still backed by LookupPregeneratedThunkByString), and improves consistency without altering the unboxing-stub resolution flow.
Pull request overview
This PR makes a small consistency/cleanup update in the WASM CoreCLR VM helper used to resolve pregenerated ReadyToRun unboxing stubs, aligning it with established VM contract patterns and keeping the stub pointer typed as void* end-to-end.
Changes:
- Replace the explicit
CONTRACTLblock inGetUnboxingStubwithSTANDARD_VM_CONTRACT. - Use
LookupPortableEntryPointThunkso the looked-up unboxing stub remains avoid*(and compare againstnullptr), avoiding extraPCODEcasts.
File summaries
| File | Description |
|---|---|
| src/coreclr/vm/wasm/helpers.cpp | Uses STANDARD_VM_CONTRACT for GetUnboxingStub and switches to LookupPortableEntryPointThunk to keep the resolved stub typed as void*. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
lewing
approved these changes
Sep 9, 2026
lewing
added a commit
to lewing/runtime
that referenced
this pull request
Sep 9, 2026
Resolve GetUnboxingStub overlap with dotnet#133461 by retaining its STANDARD_VM_CONTRACT and void-pointer lookup while returning the target entrypoint checked by the adapter guard. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STANDARD_VM_CONTRACTforGetUnboxingStubvoid*by reusingLookupPortableEntryPointThunkValidation
build.cmd clr -c release -os browserWasmVirtualMethodGenericsReadyToRun tests: 2 passedNote
This pull request description was generated with GitHub Copilot.