Add aot.slnx for working on crossgen2 and ilc at the same time

[jtschuster]

It would be nice to not have to switch between solutions when working on cross-cutting changes.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[Copilot]

🟡 Changes recommended

The combined solution omits required ILC projects, and the documented workflow does not mention it.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds aot.slnx, a combined solution for working on ILC and crossgen2 projects.

Changes:

• Adds shared project configurations and platform mappings.
• Includes ILC, crossgen2, ReadyToRun, and ILLink-related projects.

Review findings:

• Moderate (2 votes): Add the linker shared/test projects and existing Checked/Debug mappings omitted from ilc.slnx.
• Nit (1 vote): Update NativeAOT documentation to mention aot.slnx.

File summaries

File	Description
src/coreclr/tools/aot/aot.slnx	Defines the combined AOT solution and project mappings.

Review details

Suppressed comments (1)

src/coreclr/tools/aot/aot.slnx:1

• The NativeAOT build documentation still directs compiler work to ilc.slnx and lists only the existing compiler/runtime solutions (docs/workflow/building/coreclr/nativeaot.md:63-67), so this new combined solution is not discoverable through the documented workflow. Please update that solution list and the nearby workflow instructions to mention aot.slnx.

<Solution>

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

[Copilot]

🟡 Changes recommended

Configuration mappings need reconciliation, and the workflow documentation should be updated.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (2)

src/coreclr/tools/aot/aot.slnx:65

• These mappings are inherited from ilc.slnx, but they conflict with the crossgen2 project mapping: crossgen2.slnx maps ILCompiler.TypeSystem to x64 for *|Any CPU and leaves it buildable (crossgen2.slnx:52-56), whereas this block maps Any CPU to x86 and sets Build=false. Consequently, selecting Any CPU in the combined solution changes both whether TypeSystem is a selected build and which project platform is passed compared with the existing crossgen2 solution, which can make crossgen2 debugging/build output diverge. Please reconcile this shared-project mapping with the crossgen2 configuration or explicitly document the intended divergence.

[!NOTE] This review comment was generated by GitHub Copilot.

  <Project Path="ILCompiler.TypeSystem/ILCompiler.TypeSystem.csproj">
    <Platform Solution="*|Any CPU" Project="x86" />
    <Platform Solution="*|x64" Project="x64" />
    <Platform Solution="*|x86" Project="x86" />
    <Build Solution="*|Any CPU" Project="false" />

src/coreclr/tools/aot/aot.slnx:32

• This shared ILCompiler.Diagnostics entry does not preserve the established crossgen2 mapping. In crossgen2.slnx, Checked|* is mapped to project Debug (and R2RDump.slnx does the same), but this block lets Checked flow through. That is not a cosmetic difference: src/coreclr/tools/Directory.Build.props gives Checked its own optimized/DEBUG semantics, so Checked|x64 in aot.slnx produces a different diagnostics configuration from crossgen2.slnx. Please preserve the established mapping or decide and document a single merged policy for this shared project.

[!NOTE] This review comment was generated by GitHub Copilot.

  <Project Path="ILCompiler.Diagnostics/ILCompiler.Diagnostics.csproj">
    <Platform Solution="*|Any CPU" Project="x86" />
    <Platform Solution="*|x64" Project="x64" />
    <Platform Solution="*|x86" Project="x86" />
    <Build Solution="*|Any CPU" Project="false" />

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

[jkoritzinsky]

Can we add ilverification, Ilverify, and iltrim as well? They all share the managed type system code too

[MichalStrehovsky]

Can we add ilverification, Ilverify, and iltrim as well? They all share the managed type system code too

If we want to cover "everything using managed type system", we'd also need to include System.Private.TypeLoader, dotnet-pgo, r2rdump, etc and at some point it becomes pointless.

[jkoritzinsky]

I mainly mention ILVerification as it's the other place I've been burned by compilation errors that don't show up when my solution has been loaded (as compared to the other tools where that generally hasn't occurred). dotnet-pgo had hit that once or twice, but not nearly as much as ILVerification has for me.

[MichalStrehovsky]

I mainly mention ILVerification as it's the other place I've been burned by compilation errors that don't show up when my solution has been loaded (as compared to the other tools where that generally hasn't occurred). dotnet-pgo had hit that once or twice, but not nearly as much as ILVerification has for me.

I looked at this as a temporary crutch for WASM bring up. I expect the extra projects to have impact on solution load and project system responsiveness to the extent that aot.slnx would only be used by people who expect ilc/crossgen interactions, like the WASM bringup work. Not for normal daily work.

I don't mind either way.

[Copilot]

🟡 Changes recommended

Correct the unresolved ILTrim.Core project path.

Get a fresh assessment by requesting another Copilot review.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

The missing configuration mapping should be restored before approval.

Review details

Suppressed comments (1)

src/coreclr/tools/aot/aot.slnx:32

• The existing crossgen2.slnx explicitly maps every Checked solution configuration for ILCompiler.Diagnostics to the Debug project configuration. This combined solution omits that override, so selecting Checked here builds this dependency as Checked instead and no longer preserves the crossgen2 solution's known configuration mapping. Please carry over the same Checked-to-Debug mapping.

  <Project Path="ILCompiler.Diagnostics/ILCompiler.Diagnostics.csproj">
    <Platform Solution="*|Any CPU" Project="x86" />
    <Platform Solution="*|x64" Project="x64" />
    <Platform Solution="*|x86" Project="x86" />
    <Build Solution="*|Any CPU" Project="false" />

• Files reviewed: 1/1 changed files
• Comments generated: 0 new
• Review effort level: Lite

[jtschuster]

/ba-g known failure