Skip to content

Remove FEATURE_COUNT_GC_WRITE_BARRIERS due to compilation errors - #133781

Merged
EgorBo merged 2 commits into
mainfrom
copilot/delete-feature-count-gc-write-barriers
Sep 12, 2026
Merged

Remove FEATURE_COUNT_GC_WRITE_BARRIERS due to compilation errors#133781
EgorBo merged 2 commits into
mainfrom
copilot/delete-feature-count-gc-write-barriers

Conversation

Copilot AI commented Sep 12, 2026 •
edited by EgorBo
Loading

Copy link
Copy Markdown
Contributor
  • Inspect feature-specific code and complete the baseline build.
  • Remove obsolete counting code while preserving normal write barriers.
  • Run focused validation, formatting, and code/security review.

@azure-pipelines

azure-pipelines Bot commented Sep 12, 2026

Copy link
Copy Markdown
Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI linked an issue Sep 12, 2026 that may be closed by this pull request
Delete FEATURE_COUNT_GC_WRITE_BARRIERS #133780
Closed
@dotnet-policy-service

dotnet-policy-service Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Copilot AI requested a review from EgorBo September 12, 2026 14:33
@EgorBo
EgorBo marked this pull request as ready for review September 12, 2026 14:50
Copilot AI lite review requested due to automatic review settings September 12, 2026 14:50
@azure-pipelines

azure-pipelines Bot commented Sep 12, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 7 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@EgorBo

EgorBo commented Sep 12, 2026

Copy link
Copy Markdown
Member

@copilot the PR is still marked as WIP and there are unchecked checkboxes - check if anything is missing and fix that.

Copilot AI reviewed Sep 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The pull request is marked WIP and approval readiness is not unambiguous.

Pull request overview

Removes obsolete FEATURE_COUNT_GC_WRITE_BARRIERS code while preserving standard GC write barriers.

Changes:

  • Removes counting instrumentation, switches, and classification types.
  • Simplifies barrier helper declarations and generation.
  • Updates all architecture-specific call sites.
File summaries
File Description
src/coreclr/vm/jitinterface.h Restores the standard barrier declaration.
src/coreclr/vm/gchelpers.cpp Removes barrier counting instrumentation.
src/coreclr/jit/codegenxarch.cpp Updates x86/x64 barrier calls and removes stale commentary.
src/coreclr/jit/codegenwasm.cpp Updates WASM barrier calls.
src/coreclr/jit/codegenriscv64.cpp Updates RISC-V barrier calls.
src/coreclr/jit/codegenloongarch64.cpp Updates LoongArch64 barrier calls.
src/coreclr/jit/codegencommon.cpp Simplifies barrier emission.
src/coreclr/jit/codegenarm64.cpp Updates ARM64 barrier calls.
src/coreclr/jit/codegenarm.cpp Updates ARM barrier calls.
src/coreclr/jit/codegen.h Simplifies the helper declaration.
src/coreclr/inc/switches.h Removes the obsolete feature switch.
src/coreclr/inc/corjit.h Removes barrier classification types.
Review details
  • Files reviewed: 12/12 changed files
  • Comments generated: 0
  • Review effort level: Lite

Copilot AI commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot the PR is still marked as WIP and there are unchecked checkboxes - check if anything is missing and fix that.

Checked commit 1dbdae83: the removal is complete, all references are gone, and ./build.sh clr+libs+host passes with 0 warnings/errors. Two independent reviews and secret scanning found no issues. The PR is already draft: false; only the literal [WIP] title and stale body checkboxes remain. This session’s PR tool cannot edit title/body metadata without a code commit, so those metadata fields still need a manual edit.

Copilot AI requested a review from EgorBo September 12, 2026 15:22
@EgorBo EgorBo changed the title [WIP] Remove FEATURE_COUNT_GC_WRITE_BARRIERS due to compilation errors Remove FEATURE_COUNT_GC_WRITE_BARRIERS due to compilation errors Sep 12, 2026
@EgorBo
EgorBo enabled auto-merge (squash) September 12, 2026 18:36
@EgorBo

EgorBo commented Sep 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

/ba-g known issue - #133798

@EgorBo
EgorBo merged commit 6ed2ba3 into main Sep 12, 2026
142 of 145 checks passed
@EgorBo
EgorBo deleted the copilot/delete-feature-count-gc-write-barriers branch September 12, 2026 19:04
@build-analysis build-analysis Bot mentioned this pull request Sep 12, 2026
Closed
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Sep 13, 2026
Merged
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Sep 14, 2026
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 18, 2026
@EgorBo @jtschuster
Remove FEATURE_COUNT_GC_WRITE_BARRIERS due to compilation errors (dot…
5fac7e9 
…net#133781)

- Fixes dotnet#133780

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkotas jkotas jkotas approved these changes
+1 more reviewer
@EgorBo EgorBo EgorBo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@EgorBo EgorBo

Copilot code review Copilot

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

12.0-preview1

Development

Successfully merging this pull request may close these issues.

Delete FEATURE_COUNT_GC_WRITE_BARRIERS

4 participants

@EgorBo @jkotas