JIT: Preserve snapshot semantics for overlapping promoted struct copies - #133877
Merged
Merged
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix physical promotion for overlapping slices in struct copy
JIT: Preserve snapshot semantics for overlapping promoted struct copies
Sep 14, 2026
jakobbotsch
approved these changes
Sep 15, 2026
jakobbotsch
marked this pull request as ready for review
September 15, 2026 09:17
Member
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
EgorBo
approved these changes
Sep 15, 2026
This was referenced Sep 15, 2026
Member
|
/azp run runtime |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 18, 2026
…es (dotnet#133877) Physical promotion copies overlapping slices of the same local in ascending field order. When the destination starts above the source, an earlier store can overwrite a value needed by a later read. - **Copy ordering:** Reverse the completed plan in `CopyBetweenFields` only for same-local partial overlap with the destination after the source. - **Helpers:** Add `DecompositionPlan::Reverse` and `ArrayStack::Reverse`, preserving the stack’s debug mutation tracking. - **Regression coverage:** Cover both overlap directions, adjacent copies in both directions, identical offsets, and distinct locals. Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Physical promotion copies overlapping slices of the same local in ascending field order. When the destination starts above the source, an earlier store can overwrite a value needed by a later read.
CopyBetweenFieldsonly for same-local partial overlap with the destination after the source.DecompositionPlan::ReverseandArrayStack::Reverse, preserving the stack’s debug mutation tracking.