Allow intrinsic roots in partial no-JIT compilations - #134030
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/crossgen-contrib |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Review tier: Lite
Findings: None
What changed in this PR
Updates partial ReadyToRun compilation so hardware-intrinsic methods remain available on targets without runtime code generation, while preserving profile filtering elsewhere.
Changes:
- Bypasses profile exclusion for hardware intrinsics on no-JIT targets.
- Adds Wasm regression coverage for
PackedSimd,WasmBase, and non-intrinsic methods. - Allows tests to simulate both JIT-capable and non-JIT targets.
| File | Description |
|---|---|
| src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunSingleAssemblyCompilationModuleGroup.cs | Updated as part of this pull request. |
| src/coreclr/tools/aot/ILCompiler.ReadyToRun.Tests/WasmArgumentLayoutTests.cs | Updated as part of this pull request. |
jkotas
approved these changes
Sep 16, 2026
jkotas
self-requested a review
September 16, 2026 05:14
jkotas
reviewed
Sep 16, 2026
jkotas
self-requested a review
September 16, 2026 05:56
This was referenced Sep 16, 2026
Open
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add regression coverage for partial no-JIT compilations with profiles, including non-intrinsic filtering.
Get a fresh assessment by requesting another Copilot review.
Review tier: Lite
Findings: 1
Open (1)
steveisok
approved these changes
Sep 16, 2026
jkotas
approved these changes
Sep 16, 2026
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 18, 2026
## Summary - allow hardware-intrinsic methods to bypass the partial profile restriction when the target cannot generate code at runtime - preserve profile filtering for non-intrinsic methods and for all methods on JIT-capable targets This is related to dotnet#132825, where the affected compilation mode was observed, but it does not fully resolve that issue. > [!NOTE] > This pull request description was generated with GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
lewing
added a commit
that referenced
this pull request
Sep 24, 2026
## Summary - add `dotnet-pgo create-mibc-from-method-list` for constructing deterministic profile root sets from JSON - resolve assembly-qualified declaring, parameter, and generic argument types through an Ecma-backed type-system context - reject invalid JSON, missing references, unresolved or ambiguous methods, wrong generic arity, duplicate entries, open generic types, and non-`.mibc` output - document the JSON format and add focused end-to-end tests, including MIBC dump round-tripping and input-order determinism This is an exploratory, general-purpose profile-rooting tool motivated by the scenarios discussed in #132825. It does not claim to resolve that issue. The tool supports controlled differential ReadyToRun investigations without collecting a trace or hand-authoring MIBC IL. It has already been used to: - root `MemoryExtensions.Contains<int>` through `PublishReadyToRunPgoFiles`, proving the profile was accepted and the compiled body was emitted while live execution still entered `WasmR2RToInterpreterThunk`; this isolated the problem to closed-generic dispatch/adapter behavior rather than missing rooting - root `Delegate.CtorOpen` and `Delegate.CtorClosed`, proving that adding the compiled bodies did not change delegate construction dispatch or timing and ruling out missing bodies as the cause of #134564 This tool is not needed as a workaround for automatic hardware-intrinsic rooting in partial no-JIT compilations; #134030 fixed that behavior. ## Validation - `./dotnet.sh test src/coreclr/tools/dotnet-pgo/tests/dotnet-pgo.Tests.csproj -c Debug` — 7 passed - `./dotnet.sh test src/coreclr/tools/dotnet-pgo/tests/dotnet-pgo.Tests.csproj -c Release` — 7 passed - repeated default compressed generation after a delay produced identical SHA-256 hashes - an assembly-qualified array signature continued to resolve successfully - a constructed generic type with an unqualified generic argument was rejected > [!NOTE] > This pull request description was generated with GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is related to #132825, where the affected compilation mode was observed, but it does not fully resolve that issue.
Validation
./build.sh clr+libs+hostPATH=/opt/homebrew/bin:$PATH ./build.sh clr+libs -os browser -arch wasm -c Debug -cmakeargs "-DCMAKE_CXX_FLAGS=-Wno-unguarded-availability-new"PATH=/opt/homebrew/bin:$PATH ./build.sh clr+libs -os browser -arch wasm -c Release -cmakeargs "-DCMAKE_CXX_FLAGS=-Wno-unguarded-availability-new"ILCompiler.ReadyToRun.TestsDebug and Release builds forbrowser-wasmExact repro command:
crossgen2 System.Private.CoreLib.dll \ -r '<browser-wasm runtime pack>/*.dll' \ --targetarch:wasm \ --targetos:browser \ --partial \ --out:System.Private.CoreLib.wasmR2RDump --entrypointsmethod counts:PackedSimdWasmBaseNote
This pull request description was generated with GitHub Copilot.