Skip to content

[release/11.0] Disable WebSocket Clien SendAsync_Cancel_Success test - #134041

Merged
svick merged 1 commit into
dotnet:release/11.0from
rzikm:rzikm/quarantine-websocket-send-cancellation
Sep 17, 2026
Merged

svick merged 1 commit into
dotnet:release/11.0from
rzikm:rzikm/quarantine-websocket-send-cancellation

Conversation

@rzikm

@rzikm rzikm commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

Test-only change to clean up CI noise

Copilot AI lite review requested due to automatic review settings September 16, 2026 08:52
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@rzikm
rzikm requested a review from a team September 16, 2026 08:53
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Scope the skip to the affected concrete test/configuration to preserve other cancellation coverage.

Pull request overview

Disables a flaky WebSocket cancellation test on release/11.0 to reduce CI noise.

Changes:

  • Adds an ActiveIssue skip to SendAsync_Cancel_Success.
  • Makes no production-code changes.
File summaries
File Summary
src/libraries/System.Net.WebSockets.Client/tests/CancelTest.Loopback.cs Marks the shared loopback cancellation test as an active issue, currently affecting broader configurations than intended.
Review details

Suppressed comments (1)

src/libraries/System.Net.WebSockets.Client/tests/CancelTest.Loopback.cs:75

  • The linked issue reports CancelTest_HttpClient_Loopback.SendAsync_Cancel_Success, but placing [ActiveIssue] on this inherited method in CancelTest_Loopback skips the test for every concrete loopback class (SharedHandler, Invoker, HttpClient, and both HTTP/2 variants) and every SSL case. Please scope the skip to the affected concrete test/configuration so the other transport paths retain cancellation coverage.
        [ActiveIssue("https://github.com/dotnet/runtime/issues/132031")]
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

@rzikm

rzikm commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

Test only change => tell mode, approved by Karel

@rzikm rzikm added the Servicing-approved Approved for servicing release label Sep 17, 2026
@rzikm

rzikm commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

/ba-g Sockets failure is unrelated

@svick
svick merged commit 99b9021 into dotnet:release/11.0 Sep 17, 2026
104 of 109 checks passed
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-rc2 milestone Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Net Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants