Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
ManickaP
approved these changes
Sep 16, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Scope the skip to the affected concrete test/configuration to preserve other cancellation coverage.
Pull request overview
Disables a flaky WebSocket cancellation test on release/11.0 to reduce CI noise.
Changes:
- Adds an
ActiveIssueskip toSendAsync_Cancel_Success. - Makes no production-code changes.
File summaries
| File | Summary |
|---|---|
src/libraries/System.Net.WebSockets.Client/tests/CancelTest.Loopback.cs |
Marks the shared loopback cancellation test as an active issue, currently affecting broader configurations than intended. |
Review details
Suppressed comments (1)
src/libraries/System.Net.WebSockets.Client/tests/CancelTest.Loopback.cs:75
- The linked issue reports
CancelTest_HttpClient_Loopback.SendAsync_Cancel_Success, but placing[ActiveIssue]on this inherited method inCancelTest_Loopbackskips the test for every concrete loopback class (SharedHandler,Invoker,HttpClient, and both HTTP/2 variants) and every SSL case. Please scope the skip to the affected concrete test/configuration so the other transport paths retain cancellation coverage.
[ActiveIssue("https://github.com/dotnet/runtime/issues/132031")]
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
This was referenced Sep 16, 2026
wfurt
approved these changes
Sep 16, 2026
Member
Author
|
Test only change => tell mode, approved by Karel |
Member
Author
|
/ba-g Sockets failure is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only change to clean up CI noise